Apriltag measurement model #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgill92
requested changes
Nov 8, 2024
There was a problem hiding this comment.
First pass
I think we should change the name of the sensor from Apriltag pose sensor to something else because this seems more generic than just an Apriltag pose sensor. I was thinking maybe Relative Pose sensor because we are using this to process pose measurements relative to some target frame. What do you think?
bgill92
requested changes
Nov 11, 2024
fuse_models/include/fuse_models/parameters/transform_sensor_params.hpp
Outdated
Show resolved
Hide resolved
| /** | ||
| * @brief Destructor | ||
| */ | ||
| virtual ~TransformSensor() = default; |
There was a problem hiding this comment.
Is there a reason why the destructor is virtual? This sorta implies that it is okay to derive from this class?
There was a problem hiding this comment.
Yes, I think it is. I'm not 100% sure, but this is common across every fuse sensor in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an AprilTag measurement model and a tutorial using it. Also, tons of clang-tidy fixes for various source files I was looking at for reference.