Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab sim refactor #382

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Lab sim refactor #382

wants to merge 20 commits into from

Conversation

MikeWrock
Copy link
Contributor

No description provided.

@@ -48,8 +21,22 @@
type="plane"
material="groundplane"
/>
<site
name="scene_camera_optical_frame"
pos="0.0 -2.0 3.5"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkhansenbot I grabbed these numbers from here, the pos does not match. The camera angle is way off too so I'm not eve sure if they are aligned. Do you have a different (working) camera frame?

@MikeWrock MikeWrock marked this pull request as ready for review October 23, 2024 04:22
Copy link
Contributor

@mewtwoshaurd mewtwoshaurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:
On my laptop, I'm getting a lot of Mujoco model timestep not running in realtime errors -- I know that generally indicates poor performance, which I think deleting the stls and textures should help, so something seems off.
Outside of that, the robot seems in a completely unrecoverable state? I can't get teleoperate to move it anywhere, and it looks strangely positioned compared to what I'm used to with the simulator:
image
I think you mentioned the pos variables may be the issue, if you need any help testing that please let me know!

src/arm_on_rail_sim/config/config.yaml Outdated Show resolved Hide resolved
@MikeWrock
Copy link
Contributor Author

@mewtwoshaurd I added a keyframe so the arm doesn't spawn in a goofy pose, and switched the default to using the lab world. Could you please git it another test?

@MikeWrock
Copy link
Contributor Author

@mewtwoshaurd mewtwoshaurd self-requested a review October 24, 2024 15:04
@mkhansenbot
Copy link
Contributor

I'm a little confused here, is this PR supposed to replace the existing arm_on_rail_sim with the lab_sim

mewtwoshaurd
mewtwoshaurd previously approved these changes Oct 24, 2024
@mewtwoshaurd
Copy link
Contributor

works much better, thanks Michael!

@EzraBrooks EzraBrooks marked this pull request as draft October 30, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants