Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug where topEdge was not set in _get_positions_and_total_widths #45

Conversation

KukumavMozolo
Copy link

Fixed #44

@KukumavMozolo KukumavMozolo force-pushed the fix__get_positions_and_total_widths branch from bfbbc1a to 9b47dcb Compare June 10, 2024 08:10
@KukumavMozolo KukumavMozolo force-pushed the fix__get_positions_and_total_widths branch from 84f309f to 4602ce8 Compare June 10, 2024 14:52
@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.4.1 milestone Jun 10, 2024
Copy link
Owner

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

Result of what's in the test: result

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4550755 into Pierre-Sassoulas:main Jun 14, 2024
18 checks passed
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 1.4.1, 1.4.2 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in _get_positions_and_total_widths when len(lables) ==0
2 participants