Binding flow #28
Draft
Binding flow #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes easier for the user, doesn't have to access dict values in the case of single use.
of function `get_compilation_arguments`
kunaltyagi
reviewed
Aug 16, 2021
| for target in targets | ||
| } | ||
| library_targets_objs = filter( | ||
| lambda target: target.get_type() == "SHARED_LIBRARY", self.targets.values() |
There was a problem hiding this comment.
Didn't see it in pcl, so didn't get to test how it is.
There was a problem hiding this comment.
PCL_SHARED_LIBS can be used to choose between shared and static library for pcl
There was a problem hiding this comment.
Can you please provide a reference link or example?
There was a problem hiding this comment.
cmake -DPCL_SHARED_LIBS:BOOL=FALSE or similar
- `is_cursor_in_file` -> `is_cursor_in_files`: support multiple files - update `_is_valid_child` to also check for inclusion sources too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP