Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Runtime Upgrade #383

Merged
merged 1 commit into from
Sep 3, 2024
Merged

🔖 Runtime Upgrade #383

merged 1 commit into from
Sep 3, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 27, 2024

What?

  • Increase version of pallet_funding storage and polimec runtime
  • Write storage migration for new holds without project id at runtime level, and ProjectDetails changes at pallet level

Why?

  • New storage would be undecodable otherwise

Testing

We need to test it with chopsticks before merging. Try-runtime works

Anything Else?

I compared the old vs new holds and the only change was the participation

I compared the old vs new ProjectDetails and the difference was the phaseTransitionPoints being replaced with roundDuration: { start: null end: null }
and the status changed to SettlementStarted: Failure in the case of FundingFailed, and SettlementStarted:Success in the case of SettlementStarted(FundingSuccessful)

Files are here: https://linear.app/polimec/issue/PLMC-601/manual-tests#comment-9b3008c7

Copy link
Contributor Author

JuaniRios commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch 3 times, most recently from 10ad3c5 to 94677aa Compare August 30, 2024 10:50
@JuaniRios JuaniRios changed the base branch from main to 08-29-runtime-benchmarks August 30, 2024 10:50
@JuaniRios JuaniRios force-pushed the 08-29-runtime-benchmarks branch from 561d240 to c82439a Compare August 30, 2024 11:01
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from 94677aa to ff762a6 Compare August 30, 2024 11:01
@JuaniRios JuaniRios force-pushed the 08-29-runtime-benchmarks branch from c82439a to 9777af1 Compare August 30, 2024 11:32
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from ff762a6 to 4a328d7 Compare August 30, 2024 11:32
@JuaniRios JuaniRios force-pushed the 08-29-runtime-benchmarks branch from 9777af1 to 0a26d75 Compare August 30, 2024 14:29
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from 4a328d7 to 2a701d7 Compare August 30, 2024 14:29
@JuaniRios JuaniRios mentioned this pull request Aug 30, 2024
@lrazovic lrazovic force-pushed the 08-29-runtime-benchmarks branch from 0a26d75 to 3b8db19 Compare August 30, 2024 15:43
@JuaniRios JuaniRios force-pushed the 08-29-runtime-benchmarks branch from 3b8db19 to 83b8afc Compare September 2, 2024 08:33
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from 2a701d7 to ada9f02 Compare September 2, 2024 08:33
@JuaniRios JuaniRios force-pushed the 08-29-runtime-benchmarks branch from 83b8afc to 6bac2f6 Compare September 2, 2024 09:34
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from ada9f02 to 69bc130 Compare September 2, 2024 09:34
@JuaniRios JuaniRios changed the title Runtime Upgrade 🔖 Runtime Upgrade Sep 2, 2024
@JuaniRios JuaniRios marked this pull request as ready for review September 2, 2024 09:41
Copy link

graphite-app bot commented Sep 2, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (09/02/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

Let's resolve the warnings and then LGTM

@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from a909ca1 to 7345191 Compare September 3, 2024 13:20
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from 7345191 to df72942 Compare September 3, 2024 14:06
@JuaniRios JuaniRios requested a review from lrazovic September 3, 2024 14:07
Copy link
Contributor Author

JuaniRios commented Sep 3, 2024

Merge activity

  • Sep 3, 10:13 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Sep 3, 10:15 AM EDT: The Graphite merge of this pull request was cancelled.
  • Sep 3, 10:34 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios force-pushed the 08-29-runtime-benchmarks branch 2 times, most recently from 4b6181a to 00711f2 Compare September 3, 2024 14:16
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from df72942 to 348dc72 Compare September 3, 2024 14:16
@JuaniRios JuaniRios changed the base branch from 08-29-runtime-benchmarks to graphite-base/383 September 3, 2024 14:25
@JuaniRios JuaniRios force-pushed the 08-27-runtime_upgrade branch from 348dc72 to db3f6c0 Compare September 3, 2024 14:25
@JuaniRios JuaniRios changed the base branch from graphite-base/383 to main September 3, 2024 14:26
@JuaniRios JuaniRios merged commit 59222cb into main Sep 3, 2024
1 check was pending
@JuaniRios JuaniRios deleted the 08-27-runtime_upgrade branch September 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants