Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default in_app to false #147

Closed
wants to merge 3 commits into from
Closed

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Nov 27, 2024

Serde fails to parse stack frames when in_app is missing. We should default it to False if we don't know for certain it is an in_app frame

@daibhin
Copy link
Contributor Author

daibhin commented Nov 27, 2024

Actually not needed. Totally fine for the value not to be present

@daibhin daibhin closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant