Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default in_app to false #147

Closed
wants to merge 3 commits into from
Closed

fix: default in_app to false #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ad434
fix: default in_app to false
daibhin Nov 27, 2024
9cc8a29
bump versions
daibhin Nov 27, 2024
986a3ad
Merge branch 'master' into dn-fix/default-in-app-false
daibhin Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.7.5 - 2024-11-27

1. Fix a bug where `in_app` was occassionally not present on exception stack frames.

## 3.7.4 - 2024-11-25

1. Fix bug where this SDK incorrectly sent feature flag events with null values when calling `get_feature_flag_payload`.
Expand Down
3 changes: 3 additions & 0 deletions posthog/exception_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,7 @@ def set_in_app_in_frames(frames, in_app_exclude, in_app_include, project_root=No
# if frame has no abs_path, skip further checks
abs_path = frame.get("abs_path")
if abs_path is None:
frame["in_app"] = False
continue

if _is_external_source(abs_path):
Expand All @@ -743,6 +744,8 @@ def set_in_app_in_frames(frames, in_app_exclude, in_app_include, project_root=No
frame["in_app"] = True
continue

frame["in_app"] = False

return frames


Expand Down
2 changes: 1 addition & 1 deletion posthog/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION = "3.7.4"
VERSION = "3.7.5"

if __name__ == "__main__":
print(VERSION, end="") # noqa: T201
Loading