chore: remove sidebar in onboarding #29846
Open
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes the sidebar during onboarding flows to reduce user distraction, while also fixing dark mode behavior on plain pages and improving layout consistency.
- Modified
frontend/src/scenes/scenes.tsto uselayout: 'plain'for Products and Onboarding scenes instead of previous app-raw layout - Added height constraint (
h-full) infrontend/src/scenes/products/Products.tsxfor proper vertical centering - Simplified dark mode logic in
themeLogic.tsby removingsceneConfig?.layout === 'plain'condition - Replaced
BridgePagecomponent with direct flexbox styling inWizard.tsxfor cleaner layout - Added padding classes in
Onboarding.tsxto compensate for sidebar removal while maintaining proper spacing
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated20 snapshot changes in total. 0 added, 20 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -44 B (0%) Total Size: 9.93 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From looking at recordings, users get very distracted during the onboarding flow by the sidebar and all the products there
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran it locally