Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sidebar in onboarding #29846

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ export function MinimalNavigation(): JSX.Element {

return (
<nav className="flex items-center justify-between gap-2 p-2 border-b">
<span className="flex-1">
<LemonButton noPadding icon={<IconLogomark className="text-3xl" />} to={urls.projectHomepage()} />
</span>
<LemonButton noPadding icon={<IconLogomark className="text-3xl mx-2" />} to={urls.projectHomepage()} />
<div className="flex-1" />
{currentOrganization?.teams?.length ?? 0 > 1 ? (
<Popover
overlay={<ProjectSwitcherOverlay onClickInside={hideProjectSwitcher} />}
Expand Down
8 changes: 2 additions & 6 deletions frontend/src/layout/navigation-3000/themeLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,8 @@ export const themeLogic = kea<themeLogicType>([
if (theme) {
return !!theme?.dark
}
// NOTE: Unauthenticated users always get the light mode until we have full support across onboarding flows
if (
sceneConfig?.layout === 'plain' ||
sceneConfig?.allowUnauthenticated ||
sceneConfig?.onlyUnauthenticated
) {
// NOTE: Unauthenticated users always get the light mode until we have full support for dark mode there
if (sceneConfig?.allowUnauthenticated || sceneConfig?.onlyUnauthenticated) {
return false
}

Expand Down
8 changes: 6 additions & 2 deletions frontend/src/scenes/onboarding/Onboarding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,11 @@ export function Onboarding(): JSX.Element | null {
if (!product || !productKey) {
return <></>
}
const OnboardingView = onboardingViews[productKey]
const OnboardingView = onboardingViews[productKey as keyof typeof onboardingViews]

return <OnboardingView />
return (
<div className="pt-4 pb-10">
<OnboardingView />
</div>
)
}
2 changes: 1 addition & 1 deletion frontend/src/scenes/products/Products.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export function Products(): JSX.Element {
const { selectedProducts, firstProductOnboarding } = useValues(productsLogic)

return (
<div className="flex flex-col flex-1 w-full p-4 items-center justify-center bg-primary">
<div className="flex flex-col flex-1 w-full h-full p-4 items-center justify-center bg-primary">
<>
<div className="flex flex-col justify-center flex-grow items-center">
<div className="mb-2">
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/scenes/scenes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,13 @@ export const sceneConfigurations: Record<Scene | string, SceneConfig> = {
},
[Scene.Products]: {
projectBased: true,
hideProjectNotice: true,
layout: 'app-raw',
name: 'Products',
layout: 'plain',
},
[Scene.Onboarding]: {
projectBased: true,
hideBillingNotice: true,
hideProjectNotice: true,
name: 'Onboarding',
layout: 'plain',
},
[Scene.ToolbarLaunch]: {
projectBased: true,
Expand Down
5 changes: 2 additions & 3 deletions frontend/src/scenes/wizard/Wizard.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useValues } from 'kea'
import { BridgePage } from 'lib/components/BridgePage/BridgePage'
import { HeartHog, SurprisedHog } from 'lib/components/hedgehogs'
import { Spinner } from 'lib/lemon-ui/Spinner/Spinner'
import { SceneExport } from 'scenes/sceneTypes'
Expand All @@ -15,7 +14,7 @@ export function Wizard(): JSX.Element {
const { view } = useValues(wizardLogic)

return (
<BridgePage view="wizard" fixedWidth={false}>
<div className="flex h-full w-full items-center justify-center">
<div className="px-12 py-8 text-center flex flex-col items-center max-w-160 w-full">
{(view === 'pending' || view === 'creating') && (
<>
Expand All @@ -42,6 +41,6 @@ export function Wizard(): JSX.Element {
</>
)}
</div>
</BridgePage>
</div>
)
}
Loading