Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error on wrong dtype #811

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Oct 29, 2024

This should go into #803 . Do not merge into main!

Closes #774

Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers added feature New feature or request do-not-merge This should not be merged labels Oct 29, 2024
@mgovers mgovers mentioned this pull request Oct 29, 2024
27 tasks
nitbharambe
nitbharambe previously approved these changes Oct 30, 2024
@mgovers mgovers changed the base branch from main to release/v1.10.0-rc November 7, 2024 17:17
@mgovers mgovers marked this pull request as ready for review November 7, 2024 17:19
@mgovers mgovers removed the do-not-merge This should not be merged label Nov 7, 2024
@mgovers mgovers mentioned this pull request Nov 7, 2024
3 tasks
Copy link

sonarqubecloud bot commented Nov 7, 2024

@mgovers mgovers merged commit f9889a1 into release/v1.10.0-rc Nov 8, 2024
26 checks passed
@mgovers mgovers deleted the feature/error-on-type-check branch November 8, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Explicitly disallow unsupported data types (undefined behavior)
2 participants