Feat/em composition learning #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all_entries_identical()
first draft of module that implements episodic / external memory Composition
- add error message for specifcation of default_control_allocation or default_gating_allocation
- add error message for specifcation of default_control_allocation or default_gating_allocation
- add error message for specifcation of default_control_allocation or default_gating_allocation
- constructs but wiring still not right
- first draft; needs to be run
- add memory decay and storage
- storage and retrieval working
- exclude value_input_nodes as NodeRole.OUTPUT
- TODO notes
- suppress warning for no efferent projectsions
- add storage_prob and related parameters - docs in progress
- BackPropagation._function(): remove error_matrix from signature
- BackPropagation._function(): remove error_matrix from signature
- EMStorage(): partially implemented - BackPropagation._function(): remove error_matrix from signature • EMstoragemechanism.py - partially implmeneted • emcomposition.py - _construct_storage_node(): partially implemented • Project: remove residual references to System and Process
- EMStorage(): partially implemented - BackPropagation._function(): remove error_matrix from signature • EMstoragemechanism.py - partially implmeneted • emcomposition.py - _construct_storage_node(): partially implemented • Project: remove residual references to System and Process
- EMStorage(): partially implemented - BackPropagation._function(): remove error_matrix from signature • learning_mechanism.py - _instantiate_output_ports: support specification dictionary for learning_signal • projection.py - change assert to exception with improved error messages if port_spec is bad • EMstoragemechanism.py - partially implmeneted • emcomposition.py - _construct_storage_node(): partially implemented • Project: remove residual references to System and Process
- EMStorage(): partially implemented - BackPropagation._function(): remove error_matrix from signature • learning_mechanism.py - _instantiate_output_ports: support specification dictionary for learning_signal • projection.py - change assert to exception with improved error messages if port_spec is bad • EMstoragemechanism.py - implemented and passing tests • emcomposition.py - _construct_storage_node(): partially implemented • Project: remove residual references to System and Process
- EMStorage(): partially implemented - BackPropagation._function(): remove error_matrix from signature • learning_mechanism.py - _instantiate_output_ports: support specification dictionary for learning_signal • projection.py - change assert to exception with improved error messages if port_spec is bad • EMstoragemechanism.py - implemented and passing tests • emcomposition.py - _construct_storage_node(): partially implemented • Project: remove residual references to System and Process
- EMStorage(): partially implemented - BackPropagation._function(): remove error_matrix from signature • learning_mechanism.py - _instantiate_output_ports: support specification dictionary for learning_signal • projection.py - change assert to exception with improved error messages if port_spec is bad • EMstoragemechanism.py - implemented and passing tests • emcomposition.py - _construct_storage_node(): partially implemented • Project: remove residual references to System and Process
- version with EMStorageMechanism passes all tests
- Fixed import of Literal
- test_execution: add tests for concatenation • emstoragemechanism.py - implement names of learning_signals • learningmechanism.py - _instantiate_output_ports: remove imposition of "LearningSignal" as name
- docstring mods
- docstring mods
…into feat/em_composition_LEARNING
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -143,6 +143,7 @@ | |||
| """ | |||
|
|
|||
| import numpy as np | |||
| import re | |||
Check notice
Code scanning / CodeQL
Unused import Note
| self.parameters.learning_signals._set(learning_signal_dicts, context) | ||
|
|
||
| return super()._instantiate_output_ports(context=context) | ||
| learning_signals = super()._instantiate_output_ports(context=context) |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMComposition.py: docstring mods