Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add llvm_not_implemented mark #3075

Merged
merged 4 commits into from
Oct 21, 2024
Merged

tests: Add llvm_not_implemented mark #3075

merged 4 commits into from
Oct 21, 2024
+325 −401

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Oct 20, 2024

Cleanup.

Add lvm_not_implemented mark, tests with both this mark and the 'llvm' mark are automatically skipped.
Replace adhoc pytest.skip calls in unimplemented test combinations.

@jvesely
tests/IntegratorFunctions: Cleanup
ac83b2a 
Consolidate parameter overrides.
Create of copy of the params dict argument instead of modifying it.
Add testing of DriftOnASphereIntegrator.
Do not duplicate function instantiation.
Drop redundant import.

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added compiler Runtime Compiler tests Test changes labels Oct 20, 2024
@github-actions GitHub Actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.11):

diff -r docs-base/ModulatoryProjection.html docs-head/ModulatoryProjection.html
272c272
< <a class="reference internal" href="Port.html"><span class="doc">Port</span></a> are listed in the Port’s <a class="reference internal" href="ParameterPort.html#psyneulink.core.components.ports.parameterport.ParameterPort.mod_afferents" title="psyneulink.core.components.ports.parameterport.ParameterPort.mod_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">mod_afferents</span></code></a> attribute.</p>
---
> <a class="reference internal" href="Port.html"><span class="doc">Port</span></a> are listed in the Port’s <a class="reference internal" href="Mechanism.html#id7" title="psyneulink.core.components.mechanisms.mechanism.Mechanism_Base.mod_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">mod_afferents</span></code></a> attribute.</p>
diff -r docs-base/Port.html docs-head/Port.html
616c616
< <code class="xref any docutils literal notranslate"><span class="pre">PathWayProjections</span></code> (listed in its <a class="reference internal" href="#psyneulink.core.components.ports.port.Port_Base.path_afferents" title="psyneulink.core.components.ports.port.Port_Base.path_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">path_afferents</span></code></a> attribute) as the variable for its
---
> <code class="xref any docutils literal notranslate"><span class="pre">PathWayProjections</span></code> (listed in its <a class="reference internal" href="Mechanism.html#id6" title="psyneulink.core.components.mechanisms.mechanism.Mechanism_Base.path_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">path_afferents</span></code></a> attribute) as the variable for its

...

See CI logs for the full diff.

@jvesely
tests/AutodiffComposition: Cleanup use of ExecutionMode.Python
caa2a67 
Most tests checking for ExecutionMode.Python and waiving all instances
can be re-enabled with ExecutionMode.PyTorch.
Re-enabled tests:
* test_loss_specs[ExecutionMode.PyTorch-Loss.L1-expected1]
   - add current results as expected results
* test_loss_specs[ExecutionMode.PyTorch-Loss.POISSON_NLL-expected3]
   - add current results as expected results
* test_pytorch_loss_spec[ExecutionMode.PyTorch]
* test_xor_nested_no_train_then_train[ExecutionMode.PyTorch-400-4-10-1e-05]
* test_params_stay_separate[ExecutionMode.PyTorch]

Provide execution_mode=pnl.ExecutionMode.PyTorch explicitly to
AutodiffComposition.learn to avoid warnings.

Improves pytest tests/composition/test_autodiffcomposition.py -n0
from: = 65 passed, 26 skipped, 25 warnings in 154.82s (0:02:34) =
to: = 70 passed, 21 skipped, 7 warnings in 159.48s (0:02:39) =

Signed-off-by: Jan Vesely <[email protected]>
@jvesely
tests/TransferFunction: Cleanup
1239e4a 
Use top level pnl names for functions.
Codestyle.

Signed-off-by: Jan Vesely <[email protected]>
@jvesely
tests/llvm: Add llvm_not_implemented mark.
719978f 
Combination of llvm and llvm_not_implemented marks is automatically
skipped.

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely merged commit 1919965 into PrincetonUniversity:devel Oct 21, 2024
36 checks passed
@github-actions GitHub Actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.11):

diff -r docs-base/ModulatoryProjection.html docs-head/ModulatoryProjection.html
272c272
< <a class="reference internal" href="Port.html"><span class="doc">Port</span></a> are listed in the Port’s <a class="reference internal" href="ParameterPort.html#psyneulink.core.components.ports.parameterport.ParameterPort.mod_afferents" title="psyneulink.core.components.ports.parameterport.ParameterPort.mod_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">mod_afferents</span></code></a> attribute.</p>
---
> <a class="reference internal" href="Port.html"><span class="doc">Port</span></a> are listed in the Port’s <a class="reference internal" href="Mechanism.html#id7" title="psyneulink.core.components.mechanisms.mechanism.Mechanism_Base.mod_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">mod_afferents</span></code></a> attribute.</p>
diff -r docs-base/Port.html docs-head/Port.html
616c616
< <code class="xref any docutils literal notranslate"><span class="pre">PathWayProjections</span></code> (listed in its <a class="reference internal" href="#psyneulink.core.components.ports.port.Port_Base.path_afferents" title="psyneulink.core.components.ports.port.Port_Base.path_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">path_afferents</span></code></a> attribute) as the variable for its
---
> <code class="xref any docutils literal notranslate"><span class="pre">PathWayProjections</span></code> (listed in its <a class="reference internal" href="Mechanism.html#id6" title="psyneulink.core.components.mechanisms.mechanism.Mechanism_Base.path_afferents"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">path_afferents</span></code></a> attribute) as the variable for its
diff -r docs-base/TransferFunctions.html docs-head/TransferFunctions.html
2361c2361
< <p><a class="reference internal" href="OptimizationFunctions.html#psyneulink.core.components.functions.optimizationfunctions.GradientOptimization.bounds" title="psyneulink.core.components.functions.optimizationfunctions.GradientOptimization.bounds"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">bounds</span></code></a> – specifies the lower and upper limits of the result;  if there are none, the attribute is set to
---
> <p><a class="reference internal" href="#psyneulink.core.components.functions.transferfunctions.Exponential.bounds" title="psyneulink.core.components.functions.transferfunctions.Exponential.bounds"><code class="xref any py py-attr docutils literal notranslate"><span class="pre">bounds</span></code></a> – specifies the lower and upper limits of the result;  if there are none, the attribute is set to

...

See CI logs for the full diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler Runtime Compiler tests Test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvesely