MAP v1.0 Update with Holoscan support #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocsharp
added
documentation
mocsharp
force-pushed
the
vchang/map-v1.0
branch
3 times, most recently
from
1dfba2a
to
01b770a
Compare
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
|
I find reviewing the doc change with |
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
|
[like] Jonny Hancox reacted to your message:
…________________________________
From: Ming M Qin ***@***.***>
Sent: Thursday, May 18, 2023 6:50:03 AM
To: Project-MONAI/monai-deploy ***@***.***>
Cc: Jonny Hancox ***@***.***>; Review requested ***@***.***>
Subject: Re: [Project-MONAI/monai-deploy] MAP v1.0 Update with Holoscan support (PR #131)
I find reviewing the doc change with display the rich diff option much easier, https://github.com/Project-MONAI/monai-deploy/pull/131/files?short_path=59d6146#diff-59d6146f21b5f517be4e54a472a9951c90a1ed37ae8644d8f6de33f2564a3d3b
—
Reply to this email directly, view it on GitHub<#131 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALR3LRZZSTDV5FGIVZJSW2TXGXBBXANCNFSM6AAAAAAYC5HTKU>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
MMelQin
reviewed
May 18, 2023
JHancox
reviewed
May 18, 2023
JHancox
reviewed
May 18, 2023
JHancox
reviewed
May 18, 2023
JHancox
reviewed
May 18, 2023
ericspod
reviewed
Jun 26, 2023
ericspod
reviewed
Jun 26, 2023
|
I had a few very minor comments and suggestions. One suggestion that is perhaps a lot of work to propose is a table to definitions for terms like "container" or "pathname" so that it's precise what we're referring to, and so that we can link to external definitions only once. |
MMelQin
approved these changes
Jun 26, 2023
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
- Add definitions table - Change Mi to MiB and Gi to GiB - Update input/output path description - Add notes to port number range Signed-off-by: Victor Chang <[email protected]>
mocsharp
force-pushed
the
vchang/map-v1.0
branch
from
4c37fa0
to
ed72151
Compare
ericspod
approved these changes
Jun 26, 2023
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Update map behavior on printing and exporting manifest files etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes MONAI Application Package specification to version 1.0 with support for the upcoming release of MONAI Deploy App SDK based on Holoscan SDK.