-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAP v1.0 Update with Holoscan support #131
Conversation
1dfba2a
to
01b770a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I find reviewing the doc change with |
[like] Jonny Hancox reacted to your message:
…________________________________
From: Ming M Qin ***@***.***>
Sent: Thursday, May 18, 2023 6:50:03 AM
To: Project-MONAI/monai-deploy ***@***.***>
Cc: Jonny Hancox ***@***.***>; Review requested ***@***.***>
Subject: Re: [Project-MONAI/monai-deploy] MAP v1.0 Update with Holoscan support (PR #131)
I find reviewing the doc change with display the rich diff option much easier, https://github.com/Project-MONAI/monai-deploy/pull/131/files?short_path=59d6146#diff-59d6146f21b5f517be4e54a472a9951c90a1ed37ae8644d8f6de33f2564a3d3b
—
Reply to this email directly, view it on GitHub<#131 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALR3LRZZSTDV5FGIVZJSW2TXGXBBXANCNFSM6AAAAAAYC5HTKU>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
I had a few very minor comments and suggestions. One suggestion that is perhaps a lot of work to propose is a table to definitions for terms like "container" or "pathname" so that it's precise what we're referring to, and so that we can link to external definitions only once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
- Add definitions table - Change Mi to MiB and Gi to GiB - Update input/output path description - Add notes to port number range Signed-off-by: Victor Chang <[email protected]>
4c37fa0
to
ed72151
Compare
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Update map behavior on printing and exporting manifest files etc
This PR promotes MONAI Application Package specification to version 1.0 with support for the upcoming release of MONAI Deploy App SDK based on Holoscan SDK.