This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
Invites #42
Open
Invites #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullfs
reviewed
Apr 19, 2019
source/components/IconLoader.vue
Outdated
| iconClasses() { | ||
| return [ | ||
| 'simple-preloader', | ||
| '_' + this.color, |
There was a problem hiding this comment.
es6 забанили? )
`_${this.color}`
There was a problem hiding this comment.
Да, я что-то аналогичный скопипизжил и не переделал почему-то) Поправлю, спасибо)
fullfs
reviewed
Apr 19, 2019
source/stores/User.ts
Outdated
| hasAccessToModule: ( | ||
| { permissions, nextRoute }, | ||
| { currentVendorId } | ||
| ) => (resourceId: string = '') => { |
There was a problem hiding this comment.
А где-нибудь этот resourceId в итоге передаётся? )
There was a problem hiding this comment.
Он обязательно будет передаваться в Games, так как права будут по id'шнику игры, просто в rbac'е не стал все модули переводить, отдельная ветка у меня локально лежит, в ней я это сделал уже
There was a problem hiding this comment.
Отдельно уже поправил, чтобы быстрее выпустить
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Так как инвайты пилились на основе ветки с правами, а права еще не зарелижены, то смореть только последний коммит, все коммиты переребейзил туда, чтобы было проще смотреть.