Update Hamilton TipRack Names #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now that we are in the process, let's also make them lower case because they are functions. not all resource definition functions follow this pattern yet (they should, and we should fix them later), but let's not introduce more things we are gonna have to rename later. I will do this |
|
corresponding forum thread: https://discuss.pylabrobot.org/t/naming-tip-racks/150 |
rickwierenga
force-pushed
the
Update-Hamilton-tiprack-naming
branch
from
446e513 to
895f741
Compare
rickwierenga
force-pushed
the
Update-Hamilton-tiprack-naming
branch
from
895f741 to
48dc9de
Compare
|
Amazing updates, thank you @rickwierenga. I love all of them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Long been discussed, here now a first implementation of the PLR TipRack naming, starting with the (currently PLR-integrated) TipRacks from Hamilton.
Summary:
Docstrings still contain the OEM's name for information purposes and easing the transition process.
Catalogue/part numbers are a requirement.
Where part numbers are not available TODOs hint at the insecurity of the definition.
I also started collecting information regarding CORE-I vs CORE-II cat number differences inside the docstrings (this can in the future be extended for safety/compatibility checking features).
Please let me know whether you have suggestions on updating the new naming system or see etch cases.