Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated us inputs scenarios #181

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

danielelerede-oet
Copy link
Contributor

Changes proposed in this Pull Request

This PR builds on #172, and dedicated US inputs are further improved:

  1. different scenarios are taken into account for electrolyzers and DAC costs, building on the nomenclature by the NREL ATB (Conservative, Moderate, Advanced)
  2. inflation rates (generally applied to all cost values) are taken into account for values in EUR only, as the US-specific data should already consider adjustment for inflation.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@fneum
Copy link
Member

fneum commented Feb 18, 2025

This might now require a rebase.

@danielelerede-oet
Copy link
Contributor Author

Hi @fneum , in response to your comment on inflation rate on #172, here the processing of costs expressed in USD is removed as the NREL ATB and ICCT dataset for electrolysis technologies already consider the adjustment for inflation. We agree anyway about the need for a US-dedicated dataset for inflation to be applied, for instance, on Fischer-Tropsch and DAC, whose values are not adjuster for inflation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants