Circuit: Fix balance violation #78
Merged
This check has been archived and is scheduled for deletion.
Learn more about checks retention
GitHub Actions / Clippy (beta)
succeeded
Jul 11, 2023 in 0s
Clippy (beta)
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.71.0-beta.6 (01b5c40dc 2023-07-08)
- cargo 1.71.0-beta.6 (cfd3bbd8f 2023-06-08)
- clippy 0.1.71 (01b5c40 2023-07-08)
Annotations
Check warning on line 164 in src/note/commitment.rs
github-actions / Clippy (beta)
use of `default` to create a unit struct
warning: use of `default` to create a unit struct
--> src/note/commitment.rs:164:31
|
164 | let mut os_rng = OsRng::default();
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
Check warning on line 206 in tests/zsa.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> tests/zsa.rs:206:33
|
206 | proven.apply_signatures(&mut rng, sighash, &[]).unwrap()
| ^^^^^^^^ help: change this to: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 98 in tests/zsa.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> tests/zsa.rs:98:27
|
98 | .apply_signatures(&mut rng, sighash, &[SpendAuthorizingKey::from(sk)])
| ^^^^^^^^ help: change this to: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 85 in tests/zsa.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> tests/zsa.rs:85:17
|
85 | proven.sign(&mut rng, isk).unwrap()
| ^^^^^^^^ help: change this to: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Loading