Fees material in Asset Swaps ZIP (ZIP 228) #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
At present, the Specification for the fees is not filled, just the Rationale (which has all the overview, essentially). Need to discuss the concrete fees we are suggesting before moving the relevant bit from Rational to Specification, and adding any concrete values that are necessary. |
vivek-arte
changed the title
vivek-arte
force-pushed
the
asset_swaps
branch
2 times, most recently
from
122a4f6
to
2c3898a
Compare
|
Closing this in favour of #63, since there are multiple restructuring changes and conflicts in this current branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the fees material out of the Other Considerations section.