-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r0.0.2 Candidate #69
Open
ichristen
wants to merge
101
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
r0.0.2 Candidate #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ other cleanup
- Swapped None and 0 for phase_steps. - Saved the old phase calibration.
+ Tied together slm.spot_radius_kxy() and fs.get_farfield_spot_size() + Enable simulation.ipynb example
Closed
Also: - smallest_distance divide and conquer - docs polish and rejig - copied settle_time branch - pixel_calib polish - new Zernike wavefront calibration - moved Hologram.methods to .flags - quadratic initial phase - some variable hiding - parabola fitfunction - cleaned phase functions to remove offset vars (functionality is equivalent to +=)
Calibration changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging pull request for
dev
->main
forr0.0.2
. This message should be treated as an editable draft of the release notes.r0.0.2
New Features (checkbox is ready for release)
SimulatedSLM
andSimulatedCamera
, modeling experimental effects.toolbox.phase
functionssinusoid()
grating.binary()
grating.polynomial()
.lens()
which use the SLM grid are now centered on the source amplitude and will focus coaxially.convert_zernike_index()
function to convert between common indexing standards.convert_vector()
(previously known asconvert_blaze_vector()
) and new units, including:"zernike"
, which expresses 3D points as the result of coordinates (in radians) directly multiplied with normalized tilt and focus Zernike polynomials.CompressedSpotHologram
. 3D Spots #41pytorch
working alongsidecupy
.wavefront_calibrate()
that simultaneously measures at multiple calibration points.fourier_calibrate()
fitting.pixel_calibrate()
measuring phase swing and crosstalk.settle_calibrate()
measuring theformat_2vectors()
generalized toformat_vectors()
with N-dimensional support.smallest_distance()
(now can handle millions of points inBreaking Changes
toolbox.phase
functions:zernike()
andzernike_sum()
are completely changed.blaze()
had theoffset=
parameter removed as it was redundant with+=
.dx_um
,dy_um
->pitch_um
dx
,dy
->pitch
x_grid
,y_grid
->grid
phase_correction
,measured_amplitude
, ->source
Santec
,Meadowlark
, ...) should largely be fine, but direct calls to theSLM
constructor might break.Hologram
s:method
was moved toflags
.FourierSLM
:calibrations
.wavefront_calibrate()
has renamed and reorganized variables.Bugfixes
take
does not work properly for stacks of images. #53take
using even pixel number. #62Under the Hood
algorithms
is split into many smaller files.fitfunctions
andfiles
are moved frommisc
toanalysis
andtoolbox
.