Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative updates #126

Merged
merged 23 commits into from
Dec 6, 2024
Merged

Cumulative updates #126

merged 23 commits into from
Dec 6, 2024

Conversation

yalinli2
Copy link
Member

@yalinli2 yalinli2 commented Dec 6, 2024

Mainly includes:

  • Fixes in LCA-related classes.
  • Updates (more flexible) in HTL-related classes and CHP.
  • FAQ for fixing the underlying object has vanished error.
  • Addition of common cost indices.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 88.35616% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (cb6678a) to head (19486fa).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
qsdsan/_lca.py 73.52% 8 Missing and 1 partial ⚠️
qsdsan/sanunits/_combustion.py 90.24% 3 Missing and 1 partial ⚠️
qsdsan/_sanunit.py 33.33% 0 Missing and 2 partials ⚠️
qsdsan/utils/utilities.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   73.37%   73.52%   +0.14%     
==========================================
  Files          95       96       +1     
  Lines       18950    19045      +95     
  Branches     1662     1668       +6     
==========================================
+ Hits        13904    14002      +98     
+ Misses       4488     4487       -1     
+ Partials      558      556       -2     
Flag Coverage Δ
unittests 73.52% <88.35%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yalinli2
Copy link
Member Author

yalinli2 commented Dec 6, 2024

@jiananf2

FYI, this will merge in the changes in CHP as I noted here: 5e2d8f0

as well as some other HTL-related changes, but I don't expect that to affect your results, let me know if it's cause trouble tho, thanks!

@yalinli2 yalinli2 merged commit 30f7273 into main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants