-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract financing to it's own table & fix: Finance vehicle menu #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments on the migrate.sql only that apply to all the sql. Haven't reviewed lua yet.
I wouldn't repeat the table creation within the migrate.sql.
I think the best strategy here is to leave the player_vehicles table alone to preserve backwards compatibility, but use this new table in qbx_vehicleshop. That way other vehicle shop resources will continue to work by using the other table
migrate.sql should be what people execute if they already had qb / the previous versions of qbx vehicleshop, where import is ONLY used when creating a new server.
Other resources should have it's own sql file to add those, and since this change would only affect people that use OUR resource they wouldn't be impacted |
Description
Worked on #30, it shouldn't really cause any problem for backwards compat, maybe a migration would do the job?
Checklist