Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract financing to it's own table & fix: Finance vehicle menu #64

Merged
merged 18 commits into from
Mar 15, 2024

Conversation

TonybynMp4
Copy link
Contributor

@TonybynMp4 TonybynMp4 commented Feb 28, 2024

Description

Worked on #30, it shouldn't really cause any problem for backwards compat, maybe a migration would do the job?

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@TonybynMp4 TonybynMp4 requested a review from Manason February 28, 2024 07:15
@TonybynMp4 TonybynMp4 linked an issue Feb 28, 2024 that may be closed by this pull request
Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on the migrate.sql only that apply to all the sql. Haven't reviewed lua yet.

I wouldn't repeat the table creation within the migrate.sql.

I think the best strategy here is to leave the player_vehicles table alone to preserve backwards compatibility, but use this new table in qbx_vehicleshop. That way other vehicle shop resources will continue to work by using the other table

migrate.sql Outdated Show resolved Hide resolved
migrate.sql Outdated Show resolved Hide resolved
migrate.sql Outdated Show resolved Hide resolved
migrate.sql Outdated Show resolved Hide resolved
migrate.sql Outdated Show resolved Hide resolved
migrate.sql Outdated Show resolved Hide resolved
@TonybynMp4
Copy link
Contributor Author

I wouldn't repeat the table creation within the migrate.sql.

migrate.sql should be what people execute if they already had qb / the previous versions of qbx vehicleshop, where import is ONLY used when creating a new server.

I think the best strategy here is to leave the player_vehicles table alone to preserve backwards compatibility, but use this new table in qbx_vehicleshop. That way other vehicle shop resources will continue to work by using the other table

Other resources should have it's own sql file to add those, and since this change would only affect people that use OUR resource they wouldn't be impacted

migrate.sql Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
migrate.sql Show resolved Hide resolved
@TonybynMp4 TonybynMp4 requested a review from Manason March 1, 2024 20:37
server/main.lua Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
vehshop.sql Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
server/storage.lua Outdated Show resolved Hide resolved
migrate.sql Outdated Show resolved Hide resolved
@TonybynMp4 TonybynMp4 requested a review from Manason March 8, 2024 16:02
@TonybynMp4 TonybynMp4 requested a review from FjamZoo March 8, 2024 16:02
@TonybynMp4 TonybynMp4 changed the title feat: extract financing to it's own table feat: extract financing to it's own table & fix: Finance vehicle menu Mar 8, 2024
@Manason Manason merged commit 560999d into main Mar 15, 2024
4 checks passed
@Manason Manason deleted the database branch March 15, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Split Finance Into Its Own DB Table
4 participants