Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename: OneMinusFidelity(...) -> MaximizeStateFidelity(...).loss_function #35

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rename: OneMinusFidelity(...) -> MaximizeStateFidelity(...).loss_function #35

wants to merge 1 commit into from

Conversation

garrison
Copy link
Member

@garrison garrison commented Nov 15, 2024 •
edited
Loading

To do

  • properly deprecate the __call__ method
  • properly deprecate OneMinusFidelity, perhaps by using deprecate_func from qiskit?
  • create a test that uses the 0.1.0 OneMinusFidelity interface.
  • update some phrasing in the explanation. grep for "objective function"

@garrison garrison added this to the 0.2.0 milestone Nov 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11860593339

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 95.246%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_addon_aqc_tensor/objective.py 3 4 75.0%
Totals Coverage Status
Change from base Build 11835241713: -0.1%
Covered Lines: 601
Relevant Lines: 631
💛 - Coveralls

@garrison garrison mentioned this pull request Nov 27, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
objective functions
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@garrison @coveralls