Make maximum clipboard buffer lenght configurable #150
Conversation
alimirjamali
force-pushed
the
issue-9296
branch
from
5e17fb1
to
b0cb18f
Compare
alimirjamali
force-pushed
the
issue-9296
branch
7 times, most recently
from
98a0c57
to
3b1dedd
Compare
alimirjamali
force-pushed
the
issue-9296
branch
from
3b1dedd
to
0265918
Compare
alimirjamali
force-pushed
the
issue-9296
branch
from
0265918
to
3a15fee
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024102523-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable tests
|
|
I am adding a special case if user tries to press ctrl+shift+c in a qube where the clipboard is empty. This can be handled with the new metadata (copy_action=true, successful=true, cleared=true, sent_size=0) |
alimirjamali
force-pushed
the
issue-9296
branch
from
c853445
to
83b6395
Compare
|
I made another small adjustment. If |
alimirjamali
force-pushed
the
issue-9296
branch
from
83b6395
to
e1e6026
Compare
Better parsing and error handling for `/run/qubes/qubes-clipboard.bin.metadata` Fixes requested during review
alimirjamali
force-pushed
the
issue-9296
branch
from
e1e6026
to
b9aed51
Compare
|
According to the tests the copy operation for 64000 and more fails (with default config and increased limit too). I haven't found any error messages in logs (the metadata has copy_action=1, successful=1, cleared=1). |
|
Hmm, in some cases the 64k case works. But in none of the 4 iterations 200k worked. |
Was the fix I pushed to |
Looking at the comment from the bot: ...yes |
|
Ok. In the updated unittest in this line, it sets |
|
In test_002_clipboard_300k, does it expect a truncated zero byte I did the above as a temporary solution to INCR. Designing a signal from vmside to xside for the INCR is possible. |
|
For |
It intends to set the per-vm one (for the source VM specifically).
Ok, so the 300k test needs an update.
Right, the truncated one indeed should expect empty source. But I'm more worried about non-truncated one failing. |
I will look at test result again and see why it is failing. In the meantime, I am working with Marmarta on issue 9029 and will come back to this one very soon. Just for a change (classic c programming could grind mind) |
|
It could be also a race condition in the test. I've added sleep(1) after sending ctrl+shift+c for now, lets see if that changes anything. |
If this fails again, I appreciate if I could have the entire metadata. Is it possible? I am specifically interested on |
I see that |
Yes, but a different one than I thought initially. Apparently zenity needs a bit of time to process "ctrl+c" when opened with a larger text. |
1st part of fix. Making the clipboard buffer size configurable via
max_clipboard_sizesetting withinguid.conffixes: QubesOS/qubes-issues#9296