Notify if qube tried to send large clipboard #223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 93.72% 93.72% -0.01%
==========================================
Files 57 57
Lines 10845 10845
==========================================
- Hits 10165 10164 -1
- Misses 680 681 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alimirjamali
force-pushed
the
issue-9296
branch
from
e28fdcb
to
b4823b9
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024110404-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 200 fixed
Unstable tests
|
alimirjamali
force-pushed
the
issue-9296
branch
from
b4823b9
to
21e2fad
Compare
alimirjamali
force-pushed
the
issue-9296
branch
2 times, most recently
from
e6ab2a3
to
b4da0be
Compare
There was a problem hiding this comment.
I really like this! One thing is that I feel like now we have a bunch of different notifications with very different wording, and it would be good to have them more unified. A proposal:
- warning and errors probably should have error icon, see disk space widget for example icons; I think we can use dialog-warning right now for everything and I am working on more unified icon experience
-
malformed data
<b>ERROR</b>: Malformed clipboard data received from qube: <b>{vmname}</b> -
error on copy
<b>ERROR</b>: Failed to fetch clipboard data from qube: <b>{vmname}</b> -
error on paste
ERROR: Failed to paste global clipboard contents to qube: <b>{vmname}</b> -
oversize data
<b>ERROR</b>: Global clipboard size exceeded.\nQube <b>{vmname}</b> attempted to send {size} bytes to global clipboard.\nCurrent global clipboard limit is {limit}, increase limit or use <i>qvm-copy</i> to transfer large amounts of data between qubes. -
oversize data, possible truncation
<b>WARNING</b>: Global clipboard size limit exceed.\nQube <b>{vmname}</b> attempted to send {size} bytes to global clipboard.\nGlobal clipboard might have been truncated. <small>Use <i>qvm-copy</i> to transfer large amounts of data between qubes.</small> -
empty clipboard
<b>WARNING</b>: Empty qube clipboard.\nQube <b>{vmname}</b> attempted to send <b>0</b> bytes to global clipboard.
- the following don't need an icon
- success
Clipboard contents fetched from qube: <b>'{vmname}'</b>\n Copied <b>{size}</b> to the global clipboard.\n <small>Press {shortcut} in qube to paste to local clipboard.</small>
Global clipboard copied <b>{size}</b> to <b>{vmname}</b>. Global clipboard has been wiped.\n<small>Paste normally in qube (e.g. Ctrl+V).</small>".
Global clipboard copied to qube and wiped.<i/>\n<small>Paste normally in qube (e.g. Ctrl+V).</small>
- additional message
\n<small>Global clipboard has been wiped</small>
I'm very open to corrections here, just trying for more unified messages and make it more explicit that an error is an error.
Excellent suggestions. I hope that the tests & review of patches to There is more work to be done. The patches to global clipboard will allow different limits per VM (or per entire GUIVM). Using specific features which were explained in the original issue comments. And there should be a place (maybe on Global Config) to allow users to easily set them. In addition to that, I am working on issue #6641 (option to Clear inter-VM global clipboard after a certain amount of time). That one also should be added to Global Config. Overall if all of these are implemented, Qubes OS 4.3 clipboard could get much better and smarter. |
Improving clipboard message using the new GUI protocol 1.8 fixes: QubesOS/qubes-issues#9296
alimirjamali
force-pushed
the
issue-9296
branch
from
b4da0be
to
8126510
Compare
I added the support for the icons and moved all messages to top of the file. So it would be easier for review & modifications. Also applied suggestions. I think some messages might need additional work. Some of the lines are too long. In the end, we should still wait for the gui-daemon and gui-agent patches to be merged for all of this to work. clipboard_icons.mp4 |
Yeah, I think in the future Global Config -> Clipboard will be the place for this. |
fixes: QubesOS/qubes-issues#9296