Depend on edk2-ovmf-xen instead of bundling OVMF #195
Conversation
This fixes two bugs: 1. The bundled OVMF didn't support Xen, so UEFI guests failed to boot. 2. The bundled OVMF didn't include the license text alongside it. Fixes: QubesOS/qubes-issues#8625
|
Looks good, but I'd like to make a test for that first. If you want to help, take a look at simple VM startup tests in core-admin, and add one that checks if UEFI VM boots too (and test if this PR really fixes it). |
|
When I tested (an equivalent to) this myself, it was enough to get the firmware loading, but I was dumped into a UEFI shell because |
|
I'm going to insist on a test in core-admin, but if you don't want to, I can add it too. It doesn't need to test full qubes-template-based qube booting with UEFI. In fact, I believe that's very minor use case for this feature. It can be something minimal - maybe even just grub configured to print something to the console? (see the cdrom boot test, that one uses syslinux, but you get the idea). |
|
I’ll add the test. I just thought you wanted me to test that a standard Qubes VM booted with UEFI firmware (which it doesn’t). |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024110404-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 200 fixed
Unstable tests
|
This fixes two bugs:
Fixes: QubesOS/qubes-issues#8625