network: do not restart tinyproxy if DNS hasn't changed #531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 331 331
Misses 138 138 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024110404-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 200 fixed
Unstable tests
|
NetworkManager will call the hook when anything about the connection changes. In some cases (like multiple connections) this can be quite often and restarting tinyproxy each time will eventually trigger restart rate limit and keep the service down. But even if not hitting this limit, restart interrupts any download in progress. Add a check if DNS addresses actually changed since the las hook call, and restart the service only when necessary. As a side effect, this will also avoid restarting the service on DHCP lease renew. Fixes QubesOS/qubes-issues#9110
marmarek
force-pushed
the
updates-proxy-restart
branch
from
5168498
to
01aa298
Compare
NetworkManager will call the hook when anything about the connection
changes. In some cases (like multiple connections) this can be quite
often and restarting tinyproxy each time will eventually trigger restart
rate limit and keep the service down. But even if not hitting this
limit, restart interrupts any download in progress.
Add a check if DNS addresses actually changed since the las hook call,
and restart the service only when necessary.
As a side effect, this will also avoid restarting the service on DHCP
lease renew.
Fixes QubesOS/qubes-issues#9110