Initial version of MySQL frontend connector (based on Vitess) #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
force-pushed
the
mysql_vitess
branch
2 times, most recently
from
20dc912 to
fbe1269
Compare
avelanarius
commented
Jan 29, 2025
| @@ -1,6 +1,6 @@ | |||
| module github.com/QuesmaOrg/quesma/quesma | |||
|
|
|||
| go 1.23.2 | |||
| go 1.23.5 | |||
There was a problem hiding this comment.
Vitess library requires go 1.23.5
avelanarius
force-pushed
the
mysql_vitess
branch
from
fbe1269 to
f3995f3
Compare
avelanarius
changed the title
avelanarius
changed the title
avelanarius
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
pdelewski
pdelewski
reviewed
Jan 29, 2025
pdelewski
approved these changes
Jan 29, 2025
avelanarius
added a commit
to avelanarius/quesma
that referenced
this pull request
Jan 29, 2025
After QuesmaOrg#1212, go-licence-detector GitHub Actions job started failing. One of the added dependencies uses Unlicence licence, which is not on the allowlist of the default go-licence-detector rules list. Unlicence is a public-domain-equivalent licence. The default rules list already allowed similar licences, such as "CC0-1.0" and "Public Domain", so it should be OK to add Unlicence to the allowed list. The added rules.json is a default rules file with only Unlicence added. This fixes the NOTICE.MD generation with go-licence-detector.
avelanarius
added a commit
to avelanarius/quesma
that referenced
this pull request
Jan 29, 2025
After QuesmaOrg#1212, go-licence-detector GitHub Actions job started failing. One of the added dependencies uses Unlicence licence, which is not on the allowlist of the default go-licence-detector rules list. Unlicence is a public-domain-equivalent licence. The default rules list already allowed similar licences, such as "CC0-1.0" and "Public Domain", so it should be OK to add Unlicence to the allowed list. The added rules.json is a default rules file with only Unlicence added. This fixes the NOTICE.MD generation with go-licence-detector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1211, an initial (experimental) version of (TCP) passthrough MySQL processor was introduced. That processor/frontend was merely a minimally invasive TCP proxy, which snooped on the traffic, was able to recognize Query packets and potentially modify some packets. That processor/frontend required us to always have a real MySQL instance running and it was not easy for the processor to use a different SQL DB as a backend (such as Postgres).
The components in this PR are MySQL frontend connector (based on Vitess) and MySQL processor (paired with MySQL Vitess frontend connector). They try to emulate a MySQL instance and don't require having a real MySQL instance running. A disadvantage of this approach is that we have to manually construct MySQL responses (abstracted by Vitess structures).
This is still an experimental frontend/processor (alpha) and it's only a base code, on which we will further experiment.