Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/olimex-msp430-h2618: change UART config #20356

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Feb 7, 2024

Contribution description

Change UART configuration to match olimex-msp430-h1611. This allows using the olimex-msp430-arduino-uno breakout board to be used with the olimex-msp430-h2618 as well.

In addition, to minor MSP430 related doc fixes are sneaked in a individual commits.

Testing procedure

With said breakout board attached to the olimex-msp430-h2618:

make BOARD=olimex-msp430-h2618 -C examples/default flash term
make: Entering directory '/home/maribu/Repos/software/RIOT/master/examples/default'
Building application "default" for "olimex-msp430-h2618" with MCU "msp430".

"make" -C /home/maribu/Repos/software/RIOT/master/boards/common/init
"make" -C /home/maribu/Repos/software/RIOT/master/boards/olimex-msp430-h2618
"make" -C /home/maribu/Repos/software/RIOT/master/core
"make" -C /home/maribu/Repos/software/RIOT/master/core/lib
"make" -C /home/maribu/Repos/software/RIOT/master/cpu/msp430
"make" -C /home/maribu/Repos/software/RIOT/master/cpu/msp430/periph
"make" -C /home/maribu/Repos/software/RIOT/master/drivers
"make" -C /home/maribu/Repos/software/RIOT/master/drivers/periph_common
"make" -C /home/maribu/Repos/software/RIOT/master/drivers/saul
"make" -C /home/maribu/Repos/software/RIOT/master/drivers/saul/init_devs
"make" -C /home/maribu/Repos/software/RIOT/master/sys
"make" -C /home/maribu/Repos/software/RIOT/master/sys/auto_init
"make" -C /home/maribu/Repos/software/RIOT/master/sys/div
"make" -C /home/maribu/Repos/software/RIOT/master/sys/fmt
"make" -C /home/maribu/Repos/software/RIOT/master/sys/isrpipe
"make" -C /home/maribu/Repos/software/RIOT/master/sys/libc
"make" -C /home/maribu/Repos/software/RIOT/master/sys/malloc_thread_safe
"make" -C /home/maribu/Repos/software/RIOT/master/sys/newlib_syscalls_default
"make" -C /home/maribu/Repos/software/RIOT/master/sys/phydat
"make" -C /home/maribu/Repos/software/RIOT/master/sys/preprocessor
"make" -C /home/maribu/Repos/software/RIOT/master/sys/ps
"make" -C /home/maribu/Repos/software/RIOT/master/sys/saul_reg
"make" -C /home/maribu/Repos/software/RIOT/master/sys/shell
"make" -C /home/maribu/Repos/software/RIOT/master/sys/shell/cmds
"make" -C /home/maribu/Repos/software/RIOT/master/sys/stdio_uart
"make" -C /home/maribu/Repos/software/RIOT/master/sys/tsrb
/usr/lib/gcc/msp430-elf/13.2.0/../../../../msp430-elf/bin/ld: warning: /home/maribu/Repos/software/RIOT/master/examples/default/bin/olimex-msp430-h2618/default.elf has a LOAD segment with RWX permissions
   text	  data	   bss	   dec	   hex	filename
  14872	   178	  1132	 16182	  3f36	/home/maribu/Repos/software/RIOT/master/examples/default/bin/olimex-msp430-h2618/default.elf
[INFO] mspdebug binary not found - building it from source now
[INFO] mspdebug requires readline and libusb-compat headers to build
CC= CFLAGS= make -C /home/maribu/Repos/software/RIOT/master/dist/tools/mspdebug
[INFO] mspdebug binary successfully built!
/home/maribu/Repos/software/RIOT/master/dist/tools/mspdebug/mspdebug -j --expect-id "MSP430F2618" olimex "prog /home/maribu/Repos/software/RIOT/master/examples/default/bin/olimex-msp430-h2618/default.hex"
MSPDebug version 0.25 - debugging tool for MSP430 MCUs
Copyright (C) 2009-2017 Daniel Beer <[email protected]>
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Chip info database from MSP430.dll v3.15.0.1 Copyright (C) 2013 TI, Inc.

Resetting Olimex command processor...
Initializing FET...
FET protocol version is 20000007
Set Vcc: 3000 mV
Configured for JTAG (2)
Sending reset...
Using Olimex identification procedure
Device ID: 0xf26f
  Code start address: 0x3100
  Code size         : 118528 byte = 115 kb
  RAM  start address: 0x200
  RAM  end   address: 0x9ff
  RAM  size         : 2048 byte = 2 kb
Device: MSP430F2618
Number of breakpoints: 8
fet: FET returned error code 34 (Not supported by selected interface or interface is not initialized)
fet: warning: message C_IDENT3 failed
fet: FET returned NAK
warning: device does not support power profiling
Device: MSP430F2618
Erasing...
Programming...
Writing 4096 bytes at 3100...
Writing 4096 bytes at 4100...
Writing 4096 bytes at 5100...
Writing 2758 bytes at 6100...
Writing    2 bytes at ffe2...
Writing    2 bytes at fffe...
Done, 15050 bytes total
/home/maribu/Repos/software/RIOT/master/dist/tools/pyterm/pyterm -p "/dev/ttyUSB0" -b "115200"  
2024-02-07 20:08:25,595 # Connect to serial port /dev/ttyUSB0
Welcome to pyterm!
Type '/exit' to exit.
2024-02-07 20:08:26,613 # main(): This is RIOT! (Version: 2024.04-devel-148-gcbd91-boards/msp-fixup)
2024-02-07 20:08:26,613 # Welcome to RIOT!
> help
2024-02-07 20:08:28,808 # help
2024-02-07 20:08:28,811 # Command              Description
2024-02-07 20:08:28,813 # ---------------------------------------
2024-02-07 20:08:28,819 # pm                   interact with layered PM subsystem
2024-02-07 20:08:28,825 # ps                   Prints information about running threads.
2024-02-07 20:08:28,828 # reboot               Reboot the node
2024-02-07 20:08:28,833 # saul                 interact with sensors and actuators using SAUL
2024-02-07 20:08:28,836 # version              Prints current RIOT_VERSION

Issues/PRs references

None

The symbol rate has been reduced to 9,600 Bd, as the board otherwise
occasionally looses IRQs.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Feb 7, 2024
@github-actions github-actions bot added Platform: MSP Platform: This PR/issue effects MSP-based platforms Area: cpu Area: CPU/MCU ports labels Feb 7, 2024
@riot-ci
Copy link

riot-ci commented Feb 7, 2024

Murdock results

✔️ PASSED

e0535fc boards/olimex-msp430-h2618: change UART config

Success Failures Total Runtime
352 0 352 02m:11s

Artifacts

Change UART configuration to match `olimex-msp430-h1611`. This allows
using the [olimex-msp430-arduino-uno][board] breakout board to be used
with the `olimex-msp430-h2618` as well.

[board]: https://github.com/RIOT-OS/RIOT-Open-Hardware/tree/main/olimex-msp430-arduino-uno
@benpicco benpicco added this pull request to the merge queue Feb 8, 2024
Merged via the queue into RIOT-OS:master with commit c07eca7 Feb 8, 2024
27 checks passed
@maribu
Copy link
Member Author

maribu commented Feb 8, 2024

Thx :)

@maribu maribu deleted the boards/msp-fixup branch February 8, 2024 10:24
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants