cord_lc: Process truncated reads #20547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
added
the
CI: ready for build
maribu
reviewed
Apr 5, 2024
maribu
approved these changes
Apr 5, 2024
chrysn
force-pushed
the
lookup-plausibility
branch
from
2da8dbb to
c0258a0
Compare
|
I'll read Teufelchen's thumbs-up on the PR as an OK to be merged during soft freeze. |
maribu
reviewed
Apr 5, 2024
Co-Authored-By: Marian Buschsieweke <[email protected]>
chrysn
force-pushed
the
lookup-plausibility
branch
from
c0258a0 to
9820a65
Compare
|
Sent another insta-squashed fix around %d abused as %PRIuSIZE. Ready from my PoV. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Backport provided in #20552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When a Resource Directory reports overly long .well-known/core results, those might be truncated due to a limited buffer. This PR ensures that the parts that are received are processed.
It also removes zeroing of the buffer -- clif does not require C style string termination.
Testing procedure
Issues/PRs references
@maribu provided the original version of this.
@Teufelchen1, can this still go in?