Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cord_lc: Process truncated reads [backport 2024.01] #20552

Merged

Conversation

maribu
Copy link
Member

@maribu maribu commented Apr 8, 2024

Backport of #20547

Contribution description

When a Resource Directory reports overly long .well-known/core results, those might be truncated due to a limited buffer. This PR ensures that the parts that are received are processed.

It also removes zeroing of the buffer -- clif does not require C style string termination.

Testing procedure

  • Run aiocoap's aiocoap-rd
  • run examples/cord_lc with cord_lc [fe80::f30:40e4:6c93:e17d]:5683 endpoint
  • You should get error -4 indicating that there is no endpoint

Issues/PRs references

@maribu provided the original version of this.

@Teufelchen1, can this still go in?

Co-Authored-By: Marian Buschsieweke <[email protected]>
(cherry picked from commit 9820a65)
@maribu maribu added Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Apr 8, 2024
@maribu maribu enabled auto-merge April 8, 2024 08:17
@riot-ci
Copy link

riot-ci commented Apr 8, 2024

Murdock results

✔️ PASSED

41b21da cord_lc: Process truncated reads

Success Failures Total Runtime
8612 0 8613 10m:21s

Artifacts

@maribu maribu added this pull request to the merge queue Apr 8, 2024
Merged via the queue into RIOT-OS:2024.01-branch with commit e8f5882 Apr 8, 2024
30 checks passed
@maribu maribu deleted the backport/2024.01/lookup-plausibility branch April 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants