ble/skald: Always enforce URL length check #20577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: network
benpicco
approved these changes
Apr 15, 2024
Co-authored-by: benpicco <[email protected]>
Teufelchen1
force-pushed
the
fix/eddystone
branch
from
c4d5749 to
da79068
Compare
benpicco
added
Impact: minor
IMHO, since Skald is just fullfils a “push my website's URL to some persons phone” use case, I'd say it is totally fine to assume that the URL parameter is a compile-time constant. You probably want physical access to the device anyways if you need to change that URL. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Call for feedback: Should we assume somebody builds an app where the URL parameter is not a compile time constant?
If so, we need to check the length even when assertions are disabled.