Rust: Update to riot-wrappers 0.9 #20829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
added
Type: enhancement
github-actions
bot
added
Area: tests
chrysn
removed
Area: tests
This pulls in several updates for which there is no urgent need, but also no good reason *not* to do them (especially as they may contain bug fixes, even critical ones).
chrysn
force-pushed
the
riot-wrappers-0.9
branch
from
75f58e8 to
ea40036
Compare
github-actions
bot
added
Area: tests
This was previously limited to constfs due to [8], but now that that is fixed, it can show its full potential of enumerating both directories and mount points. [8]: https://gitlab.com/etonomy/riot-wrappers/-/issues/8
chrysn
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
maribu
approved these changes
Aug 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Some increase in binary size is expected due to one bug fix around the VFS access where a zero-cost version would require threading non-idiomatic nul-terminated strings through too many abstraction levels to be practical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This updates riot-wrappers from the 0.8 series to 0.9. The change log lists what happened: Most are changes that were in the pipeline for quite some time and waited for a critical mass to do a breaking change. Being breaking, this also required changes both to the provided examples and to the example modules that are referenced -- this update rolls them all into one PR.
Testing procedure
Automated tests should suffice. Run
make -C examples/rust-gcoapfor good measure.Issues/PRs references
Some related PRs are listed at https://github.com/RIOT-OS/rust-riot-wrappers/issues?q=label%3Await-for-breaking-0.9; the big 0.9 transition is also described in RIOT-OS/rust-riot-wrappers#109