Change version to 0.9, merging breaking changes #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sleep_ticks() becomes sleep() * sleep() becomes sleep_extended() Closes: #66
… it by value This is a breaking change; applications that used the old API were prone to broken file system linked lists and thus UB with some file systems (whose data in the directory struct was not the moral equivalent of Unpin). Closes: https://gitlab.com/etonomy/riot-wrappers/-/issues/8
This indicates the start of strongly breaking changes.
Merges: #108
… it bv value Merges: #104
This was referenced Aug 22, 2024
|
As a wrapping note on the manual merging: Things worked flawlessly, also because the first PR to run after this one (#110) was created after RIOT updated its own modules (as well as the referenced example-modules) in RIOT-OS/RIOT#20829 before #110 was created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the version up to 0.9 for real (after a period on 0.8.999 since #90).
Changing the version and pulling breaking changes from #104 and #108 means that this PR's CI will not pass. However, the individual PRs pulled in passed in their own PRs with "DO NOT MERGE" commits on top that bend the affected repositories (RIOT, riot-module-examples) to the respective 0.9 branch.
This PR will be merged ignoring the failing CI. Once it is published, RIOT and riot-module-examples can get their own updates that go to 0.9. The alternative to this rather brutal approach is to bend CI now to test against the branches, and then do an extra PR bending it back -- I think that the risk of things going wrong on that track are larger than those of just merging this.