vfs: Change dir API to place directory in a pin rather than returning it bv value #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it by value This is a breaking change; applications that used the old API were prone to broken file system linked lists and thus UB with some file systems (whose data in the directory struct was not the moral equivalent of Unpin). Closes: https://gitlab.com/etonomy/riot-wrappers/-/issues/8
chrysn
force-pushed
the
vfs-no-unpin
branch
6 times, most recently
from
587afa5 to
faddcbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change; applications that used the old API were prone to broken file system linked lists and thus UB with some file systems (whose data in the directory struct was not the moral equivalent of Unpin).
Closes: https://gitlab.com/etonomy/riot-wrappers/-/issues/8
Note that I don't manage to crash the system with the original issue's description any more -- most likely, Rust/LLVM nowadays does more optimizations that avoid moving things, and thus avoids the bug by happenstance.