Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests: increase test timeout #9590

Merged
merged 1 commit into from
Jul 17, 2018
Merged

unittests: increase test timeout #9590

merged 1 commit into from
Jul 17, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jul 17, 2018

Contribution description

It currently takes 1m30 to run on iotlab-m3 which is more than the 60s configured.

Issues/PRs references

Found for release testing: RIOT-OS/Release-Specs#65 (comment)

@cladmi
unittests: increase test timeout
690fdb1 
It currently takes 1m30 to run on iotlab-m3.
@cladmi cladmi added this to the Release 2018.07 milestone Jul 17, 2018
@cladmi cladmi added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jul 17, 2018
@cladmi cladmi mentioned this pull request Jul 17, 2018
Closed
46 tasks
@miri64
Copy link
Member

miri64 commented Jul 17, 2018

Mhh.... maybe instead of increasing the timeout every now and then we should actually use some other marker for sucessful tests (e.g. the some generic output parsing when OUTPUT=TEXT is set?).

@cladmi
Copy link
Contributor Author

cladmi commented Jul 17, 2018

Another thing will be to remove crypto packages from unittests.

But I would say that both are "real fixes" that could come in dedicated PRs as it now broken for the release.

Also it shows than in one release, the unittests grew by at least 30 seconds for iotlab-m3.

miri64
miri64 approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not blocking this PR, and it is the most sensible solution for the moment (though not long term). ACK

@miri64 miri64 merged commit 9421356 into RIOT-OS:master Jul 17, 2018
@cladmi cladmi mentioned this pull request Jul 17, 2018
Merged
@cladmi
Copy link
Contributor Author

cladmi commented Jul 17, 2018

Backport provided in #9591

@cladmi cladmi deleted the pr/unittest/increase_timeout branch July 18, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch
Projects
None yet
Milestone
Release 2018.07
Development

Successfully merging this pull request may close these issues.
2 participants
@cladmi @miri64