Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests: increase test timeout [backport 2018.07] #9591

Merged
merged 1 commit into from
Jul 17, 2018
Merged

unittests: increase test timeout [backport 2018.07] #9591

merged 1 commit into from
Jul 17, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jul 17, 2018

Backport of #9590

Contribution description

It currently takes 1m30 to run on iotlab-m3 which is more than the 60s configured.

Issues/PRs references

Found for release testing: RIOT-OS/Release-Specs#65 (comment)

@cladmi
unittests: increase test timeout
6b49ecb 
It currently takes 1m30 to run on iotlab-m3.

(cherry picked from commit 690fdb1)
@cladmi cladmi added Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tests Area: tests and testing framework labels Jul 17, 2018
@cladmi cladmi requested a review from miri64 July 17, 2018 15:51
@cladmi cladmi mentioned this pull request Jul 17, 2018
Merged
@cladmi
Copy link
Contributor Author

cladmi commented Jul 17, 2018

Re-tested and the timeout is still ok when on the release branch.

miri64
miri64 approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

アク

@miri64
Copy link
Member

miri64 commented Jul 17, 2018

(failed tests are unrelated)

@miri64
Copy link
Member

miri64 commented Jul 17, 2018

The usual three:

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 17, 2018
@miri64
Copy link
Member

miri64 commented Jul 17, 2018

For what is the backporting of this PR required (it has the backporting-needed label)

@miri64 miri64 merged commit 6dda3b2 into RIOT-OS:2018.07-branch Jul 17, 2018
@cladmi cladmi removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jul 18, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Jul 18, 2018

It is the script that did not remove "backporting-needed".

@cladmi
Copy link
Contributor Author

cladmi commented Jul 18, 2018

The label was renamed recently. I updated the pr script.

@cladmi cladmi mentioned this pull request Jul 18, 2018
Merged
4 tasks
@cladmi cladmi deleted the 2018.07/pr/unittest/increase_timeout branch July 25, 2018 12:49
@cladmi cladmi added this to the Release 2018.07 milestone Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master
Projects
None yet
Milestone
Release 2018.07
Development

Successfully merging this pull request may close these issues.
2 participants
@cladmi @miri64