Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update MIPS toolchain version #76

Merged
merged 2 commits into from
Sep 23, 2019
Merged

update MIPS toolchain version #76

merged 2 commits into from
Sep 23, 2019

Conversation

kaspar030
Copy link
Contributor

This upgrades the MIPS toolchain to the latest version.

Supercedes #47.

@kaspar030 kaspar030 mentioned this pull request Jul 18, 2019
Closed
@fjmolinas
Copy link
Contributor

@kaspar030 do we need to do this if there are plans to remove mips RIOT-OS/RIOT#11788.

Otherwise, I was able to build the image but I have no hardware to test it.

@fjmolinas
Copy link
Contributor

Otherwise, I was able to build the image but I have no hardware to test it.

Could you provide some kind of test output?

@kaspar030 kaspar030 force-pushed the pr/mips-link branch 2 times, most recently from 2c7434b to a9ac74c Compare August 9, 2019 08:07
@kaspar030
Copy link
Contributor Author

do we need to do this if there are plans to remove mips RIOT-OS/RIOT#11788.

IMO that's just a suggestion. Removal of mips might happen later if it maintanance doesn't improve.

@fjmolinas
Copy link
Contributor

IMO that's just a suggestion. Removal of mips might happen later if it maintanance doesn't improve.

Ok I re-read the discussion thread, there doesn't seem to be a clear agreement yet.

@fjmolinas
Copy link
Contributor

Could you provide some kind of test output?

Since I have no hardware to test

@kaspar030 kaspar030 mentioned this pull request Aug 9, 2019
Merged
@kaspar030
Copy link
Contributor Author

We have a chicken and egg problem. The new toolchain from this PR fails on 2019.04. There's a fix in RIOT-OS/RIOT#11986. Anyhow, travis for this repo will (currently) always use 2019.04.

Ideas? Maybe first switch to 2019.07, then merge #11986, then backport to 2019.07-release?
Please let's not postpone merging this PR until 2019.10...
@MrKevinWeiss, it is "your release", what do you think?

@miri64
Copy link
Member

miri64 commented Aug 9, 2019

Weren't we thinking about release specific tags for this repo anyways (#64)?

@MrKevinWeiss
Copy link

Ya, I think there were a few things that people still wanted in the release, at least @miri64 and @cladmi had some.

@francois-berder
Copy link

I downloaded the MIPS toolchain 2018.09-03 using the link found in the Dockerfile. I did a clean build of RIOT PR #12227, including the diff I mentioned in this PR. The board was printing the correct message over UART.

benpicco
benpicco approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested by @francois-berder

ACKing to get that out of the way for sorting out the merge order.

@kaspar030 kaspar030 mentioned this pull request Sep 23, 2019
Merged
@benpicco
Copy link
Contributor

So if we trigger Murdock again, this should work now?

@kaspar030
Copy link
Contributor Author

So if we trigger Murdock again, this should work now?

it should!

@kaspar030
Copy link
Contributor Author

Somehow this exact PR gets scheduled to a travis worker that seems to be hopelessly overloaded...

@benpicco
Copy link
Contributor 

The command "eval git clone --depth=50 https://github.com/RIOT-OS/riotdocker.git RIOT-OS/riotdocker " failed 3 times.
$ cd RIOT-OS/riotdocker
/home/travis/.travis/functions: line 109: cd: RIOT-OS/riotdocker: No such file or directory

😕

Joakim Nohlgård and others added 2 commits September 23, 2019 13:57
@kaspar030
Update MIPS toolchain URL and installation procedure
4bdda20 
After unpacking, remove documentation and deduplicate identical binaries
by using hardlinks to save space.
@kaspar030
bump mips toolchain version to 2018.09-03
b3cf777
@kaspar030
Copy link
Contributor Author

Now it went through! &go

@kaspar030 kaspar030 merged commit da0c5d9 into RIOT-OS:master Sep 23, 2019
@kaspar030 kaspar030 deleted the pr/mips-link branch September 23, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaspar030 @fjmolinas @miri64 @MrKevinWeiss @francois-berder @benpicco