Skip to content

update(cherryusb): update to v1.5.0 #10409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sakumisu
Copy link
Contributor

@sakumisu sakumisu commented Jun 17, 2025

拉取/合并请求描述:(PR description)

ST board 中底层初始化不再需要,由cherryusb 中 usb_glue_st.c 实现

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

Copy link

github-actions bot commented Jun 17, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_mcxn

Path: bsp/nxp/mcx/mcxn
Reviewers: hywing

Changed Files (Click to expand)
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/Kconfig
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/SConscript
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/usb.h
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/usb_config.h
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/usb_phy.h

🏷️ Tag: bsp_rt-spark

Path: bsp/stm32/stm32f407-rt-spark
Reviewers: Rbb666 kurisaW

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-rt-spark/board/ports/cherryusb/cherryusb.c
  • bsp/stm32/stm32f407-rt-spark/board/ports/cherryusb/usb_config.h

🏷️ Tag: bsp_stm32

Path: bsp/stm32
Reviewers: wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-rt-spark/board/ports/cherryusb/cherryusb.c
  • bsp/stm32/stm32f407-rt-spark/board/ports/cherryusb/usb_config.h
  • bsp/stm32/stm32l496-st-nucleo/board/port/cherryusb/cherryusb.c
  • bsp/stm32/stm32l496-st-nucleo/board/port/cherryusb/usb_config.h

📊 Current Review Status (Last Updated: 2025-06-18 01:45 UTC)

  • Rbb666 Pending Review
  • hywing Pending Review
  • kurisaW Pending Review
  • wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@@ -6,7 +6,6 @@ cwd = GetCurrentDir()
src = Split("""
board.c
cherryusb_port.c
usb_phy.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usb_phy.c文件可以删除了么,我看见usb_phy.h也删掉了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以了,已经放在 port/nxp/usb_glue_mcx.c 里面了

@kurisaW
Copy link
Member

kurisaW commented Jun 18, 2025

CI看起来存在问题:
bsp:stm32/stm32l496-st-nucleo
attachconfig:component.cherryusb_cdc

image

@sakumisu
Copy link
Contributor Author

CI看起来存在问题: bsp:stm32/stm32l496-st-nucleo attachconfig:component.cherryusb_cdc

image

漏了,已修复

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants