-
Notifications
You must be signed in to change notification settings - Fork 5.2k
update(cherryusb): update to v1.5.0 #10409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📌 Code Review Assignment🏷️ Tag: bsp_mcxnPath: Changed Files (Click to expand)
🏷️ Tag: bsp_rt-sparkPath: Changed Files (Click to expand)
🏷️ Tag: bsp_stm32Path: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-06-18 01:45 UTC)
📝 Review Instructions
|
Signed-off-by: sakumisu <[email protected]>
@@ -6,7 +6,6 @@ cwd = GetCurrentDir() | |||
src = Split(""" | |||
board.c | |||
cherryusb_port.c | |||
usb_phy.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usb_phy.c文件可以删除了么,我看见usb_phy.h也删掉了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以了,已经放在 port/nxp/usb_glue_mcx.c 里面了
Signed-off-by: sakumisu <[email protected]>
拉取/合并请求描述:(PR description)
ST board 中底层初始化不再需要,由cherryusb 中 usb_glue_st.c 实现
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up