Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dronecan pmw module #24

Merged
merged 45 commits into from
May 5, 2024
Merged

add dronecan pmw module #24

merged 45 commits into from
May 5, 2024

Conversation

AsiiaPine
Copy link
Collaborator

add pwm module for dronecan application with real pwm publishing via uavcan.equipment.esc.Status.

AsiiaPine and others added 30 commits March 13, 2024 16:53
@AsiiaPine
add circuit status
b0e9c64
@AsiiaPine
clean up
121f61d
@AsiiaPine
rm legacy
0f3376d
@AsiiaPine
upd libparams
e87250a
@AsiiaPine
upd libparams branch
3665467
@AsiiaPine
Merge pull request #1 from AsiiaPine/pr-add-curcuit-status
87c8e22 
add circuit status
@AsiiaPine
chanhged trigger action on pull_request
ce86edb
@AsiiaPine
restore prev tools version
01f3842
@AsiiaPine
fix last-row issue
5cab4f4
@AsiiaPine
add circuit status driver
d68dbdb
@AsiiaPine
fix cyphal
5348a4c
@AsiiaPine
upd circuit_periphery and dlt dronecan tokens
9be5149
@AsiiaPine
upd Cyphal submodule
67e7934
@AsiiaPine
add pwm Module
84277c3
@AsiiaPine
upd module structure for multiple pwms
2d35951
@AsiiaPine
add ch<0 case processing
4a6336b
@AsiiaPine
replace msg publishing to esc status
452de53
@AsiiaPine
upd publishing msgs
e5e8ca2
@AsiiaPine
add dbg parameter to change pwm Status pub frequency
2cd1c67
@PonomarevDA @AsiiaPine
ci: update actions/checkout from v3 to v4, add missed build cyphal bi…
37d50fd 
…nary and upload dronecan artifacts
@PonomarevDA @AsiiaPine
update readme
029f1fc
@PonomarevDA @AsiiaPine
ci: add dronecan submodule instead of using private repo
6548491
@AsiiaPine
add circuit status (RaccoonlabDev#19)
a9dfc30
@PonomarevDA @AsiiaPine
add v3 version (stm32g0) (RaccoonlabDev#21)
06bba50
@PonomarevDA @AsiiaPine
clean up cyphal application
456ba7f
@PonomarevDA @AsiiaPine
update license
c16de88
@PonomarevDA @AsiiaPine
add cpplint for cyphal
0c772e7
@PonomarevDA @AsiiaPine
add cpplint for dronecan
e2ecc5f
@PonomarevDA @AsiiaPine
add cpplint for periphery
c3d5f55
@PonomarevDA @AsiiaPine
fix a few sonarcloud issues
fef4498
PonomarevDA
PonomarevDA requested changes Apr 22, 2024
View reviewed changes
Src/dronecan_application/params.yaml Outdated Show resolved Hide resolved
Src/dronecan_application/params.yaml Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
PonomarevDA
PonomarevDA requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@PonomarevDA PonomarevDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it. If all parameters are configured correctly, it works. Please, check a few notes.

Src/dronecan_application/params.yaml Outdated Show resolved Hide resolved
Src/dronecan_application/params.yaml Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
Src/dronecan_application/modules/PWMModule.cpp Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarCloud

@PonomarevDA PonomarevDA merged commit 651d475 into RaccoonlabDev:main May 5, 2024
5 of 7 checks passed
@PonomarevDA PonomarevDA added the enhancement New feature or request label May 5, 2024
@PonomarevDA PonomarevDA mentioned this pull request May 6, 2024
Closed
@PonomarevDA PonomarevDA changed the title Pr new pmw module add dronecan pmw module May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PonomarevDA PonomarevDA PonomarevDA approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsiiaPine @PonomarevDA