Fixed resolving of path to support PSDrives #61
Conversation
`Resolve-Path` does not resolve PSDrives, which are not supported as WorkingDirectory. This was already observed in Pester: pester/Pester#1029
# Conflicts: # BuildHelpers/Public/Get-ProjectName.ps1
| @@ -41,19 +43,19 @@ function Get-ModuleAliases { | |||
| $params = @{ | |||
| Force = $True | |||
| Passthru = $True | |||
| Name = $Name | |||
| Name = Get-FullPath $Name | |||
There was a problem hiding this comment.
I assume this will always be a path, but comment based help could use a tweak to avoid confusion (i.e. it's not either a name or path, it's a path and only a path)?
| @@ -41,19 +43,19 @@ function Get-ModuleFunctions { | |||
| $params = @{ | |||
| Force = $True | |||
| Passthru = $True | |||
| Name = $Name | |||
| Name = Get-FullPath $Name | |||
There was a problem hiding this comment.
Same here - I assume this will always be a path, but comment based help could use a tweak to avoid confusion (i.e. it's not either a name or path, it's a path and only a path)?
There was a problem hiding this comment.
I don't follow.
CBH on Get-FullPath?
Or using a named parameter instead of positioned?
There was a problem hiding this comment.
Oh sorry! To clarify, for all of these, they're used with Import-Module -Name - i.e. could be either a Path, or a Name. It really should always be a path in the context of buildhelpers, but comment based help for Name still mentions it: Name or path to module to inspect.
| { | ||
| $ExpectedManifest | ||
| } | ||
| $ThisFolder = $_ |
There was a problem hiding this comment.
Is there an auto formatter at work? Seeing some odd behavior (e.g. here I wouldn't expect foreach cmdlet to be in line with it's scriptblock content)?
There was a problem hiding this comment.
VS Code formatting.
I will fix this
| @@ -44,17 +46,17 @@ function Set-ModuleAliases { | |||
| $params = @{ | |||
| Force = $True | |||
| Passthru = $True | |||
| Name = $Name | |||
| Name = Get-FullPath $Name | |||
There was a problem hiding this comment.
Same note on comment based help
|
Alrighty! Apart some whitespace / formatting oddities and a few comment based help things that aren't accurate (but are very unlikely to be used - can still bump version just in case), looks good to me! |
lipkau
force-pushed
the
fix/PSDriveInPath
branch
from
9e0f515 to
9cc8a58
Compare
Resolve-Pathdoes not resolve PSDrives, which are not supported as WorkingDirectory.This was already observed in Pester:
pester/Pester#1029