Fixed resolving of path to support PSDrives

BuildHelpers/Private/Get-FullPath.ps1

@@ -0,0 +1,14 @@
+function Get-FullPath ([string]$Path) {
+    # https://github.com/pester/Pester/blob/5796c95e4d6ff5528b8e14865e3f25e40f01bd65/Functions/TestResults.ps1#L13-L27
+    $Folder = Split-Path -Path $Path -Parent
+    $File = Split-Path -Path $Path -Leaf
+    if ( -not ([String]::IsNullOrEmpty($Folder))) {
+        $FolderResolved = Resolve-Path -Path $Folder
+    }
+    else {
+        $FolderResolved = Resolve-Path -Path $ExecutionContext.SessionState.Path.CurrentFileSystemLocation
+    }
+    $Path = Join-Path -Path $FolderResolved.ProviderPath -ChildPath $File
+
+    return $Path
+}

BuildHelpers/Public/Add-TestResultToAppveyor.ps1

@@ -1,4 +1,5 @@
-function Add-TestResultToAppveyor {
+function Add-TestResultToAppveyor
+{
     <#
     .SYNOPSIS
         Upload test results to AppVeyor
@@ -27,30 +28,38 @@ function Add-TestResultToAppveyor {
 
         # List of files to be uploaded
         [Parameter(Mandatory,
-                   Position,
-                   ValueFromPipeline,
-                   ValueFromPipelineByPropertyName,
-                   ValueFromRemainingArguments
+            Position,
+            ValueFromPipeline,
+            ValueFromPipelineByPropertyName,
+            ValueFromRemainingArguments
         )]
+        [ValidateNotNullOrEmpty()]
+        [ValidateScript({ Test-Path $_ })]
         [Alias("FullName")]
         [string[]]
         $TestFile
     )
 
-    begin {
-            $wc = New-Object 'System.Net.WebClient'
+    begin
+    {
+        $wc = New-Object 'System.Net.WebClient'
     }
 
-    process {
-        foreach ($File in $TestFile) {
-            if (Test-Path $File) {
+    process
+    {
+        foreach ($File in $TestFile)
+        {
+            $file = Get-FullPath $file
+            if (Test-Path $File)
+            {
                 Write-Verbose "Uploading $File for Job ID: $APPVEYOR_JOB_ID"
                 $wc.UploadFile("https://ci.appveyor.com/api/testresults/$ResultType/$($APPVEYOR_JOB_ID)", $File)
             }
         }
     }
 
-    end {
+    end
+    {
         $wc.Dispose()
     }
-}
+}

BuildHelpers/Public/Find-NugetPackage.ps1

@@ -1,6 +1,7 @@
 # All credit and major props to Joel Bennett for this simplified solution that doesn't depend on PowerShellGet
 # https://gist.github.com/Jaykul/1caf0d6d26380509b04cf4ecef807355
-function Find-NugetPackage {
+function Find-NugetPackage
+{
     <#
     .SYNOPSIS
         Query a Nuget feed for details on a package
@@ -58,6 +59,7 @@ function Find-NugetPackage {
     param(
         # The name of a package to find
         [Parameter(Mandatory)]
+        [ValidateNotNullOrEmpty()]
         $Name,
         # The repository api URL -- like https://www.powershellgallery.com/api/v2/ or https://www.nuget.org/api/v2/
         $PackageSourceUrl = 'https://www.powershellgallery.com/api/v2/',
@@ -86,16 +88,20 @@ function Find-NugetPackage {
     }
 
     Invoke-RestMethod $URI | 
-    Select-Object @{n='Name';ex={$_.title.('#text')}},
-                  @{n='Author';ex={$_.author.name}},
-                  @{n='Version';ex={
-                    if($_.properties.NormalizedVersion){
-                      $_.properties.NormalizedVersion
-                    }else{
-                      $_.properties.Version
-                    }
-                  }},
-                  @{n='Uri';ex={$_.Content.src}},
-                  @{n='Description';ex={$_.properties.Description}},
-                  @{n='Properties';ex={$_.properties}}
+        Select-Object @{n='Name';ex={$_.title.('#text')}},
+    @{n='Author';ex={$_.author.name}},
+    @{n='Version';ex={
+            if($_.properties.NormalizedVersion)
+            {
+                $_.properties.NormalizedVersion
+            }
+            else
+            {
+                $_.properties.Version
+            }
+        }
+    },
+    @{n='Uri';ex={$_.Content.src}},
+    @{n='Description';ex={$_.properties.Description}},
+    @{n='Properties';ex={$_.properties}}
 }

BuildHelpers/Public/Get-BuildEnvironment.ps1

@@ -65,6 +65,7 @@ function Get-BuildEnvironment {
     [cmdletbinding()]
     param(
         [validatescript({ Test-Path $_ -PathType Container })]
+        [ValidateNotNullOrEmpty()]
         $Path = $PWD.Path,
 
         [string]$BuildOutput = '$ProjectPath\BuildOutput',
@@ -81,7 +82,7 @@ function Get-BuildEnvironment {
         [validateset('object', 'hashtable')]
         [string]$As = 'object'
     )
-    $GBVParams = @{Path = $Path}
+    $GBVParams = @{Path = Get-FullPath $Path}
     if($PSBoundParameters.ContainsKey('GitPath'))
     {
         $GBVParams.add('GitPath', $GitPath)
@@ -116,4 +117,4 @@ function Get-BuildEnvironment {
     if($As -eq 'hashtable') {
         return $BuildHelpersVariables
     }
-}
+}

BuildHelpers/Public/Get-BuildVariables.ps1

@@ -1,4 +1,5 @@
-function Get-BuildVariables {
+function Get-BuildVariables
+{
     <#
     .SYNOPSIS
         Normalize build system variables
@@ -61,20 +62,23 @@ function Get-BuildVariables {
     #>
     [cmdletbinding()]
     param(
+        [ValidateNotNullOrEmpty()]
         $Path = $PWD.Path,
+
         [validatescript({
-            if(-not (Get-Command $_ -ErrorAction SilentlyContinue))
-            {
-                throw "Could not find command at GitPath [$_]"
-            }
-            $true
-        })]
+                if(-not (Get-Command $_ -ErrorAction SilentlyContinue))
+                {
+                    throw "Could not find command at GitPath [$_]"
+                }
+                $true
+            })]
         $GitPath = 'git'
     )
 
-    $Path = ( Resolve-Path $Path ).Path
+    $Path = Get-FullPath $Path
     $Environment = Get-Item ENV:
-    if(!$PSboundParameters.ContainsKey('GitPath')) {
+    if(!$PSboundParameters.ContainsKey('GitPath'))
+    {
         $GitPath = (Get-Command $GitPath -ErrorAction SilentlyContinue)[0].Path
     }
 
@@ -117,9 +121,12 @@ function Get-BuildVariables {
     }
     if(-not $BuildRoot)
     {
-        if ($BuildSystem -eq 'Teamcity') {
+        if ($BuildSystem -eq 'Teamcity')
+        {
             $BuildRoot = $tcProperties['teamcity.build.checkoutDir']
-        } else {
+        }
+        else
+        {
             # Assumption: this function is defined in a file at the root of the build folder
             $BuildRoot = $Path
         }
@@ -149,53 +156,61 @@ function Get-BuildVariables {
     # Find the git commit message
     $CommitMessage = switch ($Environment.Name)
     {
-        'APPVEYOR_REPO_COMMIT_MESSAGE' {
+        'APPVEYOR_REPO_COMMIT_MESSAGE'
+        {
             "$env:APPVEYOR_REPO_COMMIT_MESSAGE $env:APPVEYOR_REPO_COMMIT_MESSAGE_EXTENDED".TrimEnd()
             break
         }
-        'CI_COMMIT_SHA' {
+        'CI_COMMIT_SHA'
+        {
             if($WeCanGit)
             {
                 Invoke-Git @IGParams -Arguments "log --format=%B -n 1 $( (Get-Item -Path "ENV:$_").Value )"
                 break
             } # Gitlab 9.0+ - thanks to mipadi http://stackoverflow.com/a/3357357/3067642
         }
-        'CI_BUILD_REF' {
+        'CI_BUILD_REF'
+        {
             if($WeCanGit)
             {
                 Invoke-Git @IGParams -Arguments "log --format=%B -n 1 $( (Get-Item -Path "ENV:$_").Value )"
                 break
             } # Gitlab 8.x - thanks to mipadi http://stackoverflow.com/a/3357357/3067642
         }
-        'GIT_COMMIT' {
+        'GIT_COMMIT'
+        {
             if($WeCanGit)
             {
                 Invoke-Git @IGParams -Arguments "log --format=%B -n 1 $( (Get-Item -Path "ENV:$_").Value )"
                 break
             } # Jenkins - thanks to mipadi http://stackoverflow.com/a/3357357/3067642
         }
-        'BUILD_SOURCEVERSION' {
+        'BUILD_SOURCEVERSION'
+        {
             if($WeCanGit)
             {
                 Invoke-Git @IGParams -Arguments "log --format=%B -n 1 $( (Get-Item -Path "ENV:$_").Value )"
                 break
             } # VSTS (https://www.visualstudio.com/en-us/docs/build/define/variables#)
         }
-        'BUILD_VCS_NUMBER' {
+        'BUILD_VCS_NUMBER'
+        {
             if($WeCanGit)
             {
                 Invoke-Git @IGParams -Arguments "log --format=%B -n 1 $( (Get-Item -Path "ENV:$_").Value )"
                 break
             } # Teamcity https://confluence.jetbrains.com/display/TCD10/Predefined+Build+Parameters
         }
-        'BAMBOO_REPOSITORY_REVISION_NUMBER' {
+        'BAMBOO_REPOSITORY_REVISION_NUMBER'
+        {
             if($WeCanGit)
             {
                 Invoke-Git @IGParams -Arguments "log --format=%B -n 1 $( (Get-Item -Path "ENV:$_").Value )"
                 break
             } # Bamboo https://confluence.atlassian.com/bamboo/bamboo-variables-289277087.html
         }
-        'TRAVIS_COMMIT_MESSAGE' {
+        'TRAVIS_COMMIT_MESSAGE'
+        {
             "$env:TRAVIS_COMMIT_MESSAGE"
             break
         }

BuildHelpers/Public/Get-GitChangedFile.ps1

@@ -51,6 +51,7 @@ function Get-GitChangedFile {
     [cmdletbinding()]
     param(
         [validateScript({ Test-Path $_ -PathType Container })]
+        [ValidateNotNullOrEmpty()]
         $Path = $PWD.Path,
 
         $Commit,
@@ -61,7 +62,7 @@ function Get-GitChangedFile {
 
         [switch]$Resolve
     )
-    $Path = (Resolve-Path $Path).Path
+    $Path = Get-FullPath $Path
     $GitPathRaw = Invoke-Git rev-parse --show-toplevel -Path $Path
     Write-Verbose "Found git root [$GitPathRaw]"
     $GitPath = Resolve-Path $GitPathRaw
@@ -112,4 +113,4 @@ function Get-GitChangedFile {
     {
         Write-Warning "Something went wrong, no files returned:`nIs [$Path], with repo root [$GitPath] a valid git path?"
     }
-}
+}

BuildHelpers/Public/Get-ModuleAliases.ps1

@@ -1,4 +1,5 @@
-function Get-ModuleAliases {
+function Get-ModuleAliases
+{
     <#
     .SYNOPSIS
         List aliases imported by a module
@@ -27,6 +28,7 @@ function Get-ModuleAliases {
     [cmdletbinding()]
     param(
         [parameter(ValueFromPipeline = $True)]
+        [ValidateNotNullOrEmpty()]
         [Alias('Path')]
         [string]$Name
     )
@@ -41,19 +43,19 @@ function Get-ModuleAliases {
         $params = @{
             Force = $True
             Passthru = $True
-            Name = $Name
+            Name = Get-FullPath $Name
         }
 
         # Create a runspace, add script to run
         $PowerShell = [Powershell]::Create()
         [void]$PowerShell.AddScript({
-            Param ($Force, $Passthru, $Name)
-            Import-Module -Name $Name -PassThru:$Passthru -Force:$Force
+                Param ($Force, $Passthru, $Name)
+                Import-Module -Name $Name -PassThru:$Passthru -Force:$Force
 
-        }).AddParameters($Params)
+            }).AddParameters($Params)
 
         ( $PowerShell.Invoke() ).ExportedAliases.Keys
 
         $PowerShell.Dispose()
     }
-}
+}

BuildHelpers/Public/Get-ModuleFunctions.ps1

@@ -1,4 +1,5 @@
-function Get-ModuleFunctions {
+function Get-ModuleFunctions
+{
     <#
     .SYNOPSIS
         List functions imported by a module
@@ -27,6 +28,7 @@ function Get-ModuleFunctions {
     [cmdletbinding()]
     param(
         [parameter(ValueFromPipeline = $True)]
+        [ValidateNotNullOrEmpty()]
         [Alias('Path')]
         [string]$Name
     )
@@ -41,19 +43,19 @@ function Get-ModuleFunctions {
         $params = @{
             Force = $True
             Passthru = $True
-            Name = $Name
+            Name = Get-FullPath $Name
         }
 
         # Create a runspace, add script to run
         $PowerShell = [Powershell]::Create()
         [void]$PowerShell.AddScript({
-            Param ($Force, $Passthru, $Name)
-            Import-Module -Name $Name -PassThru:$Passthru -Force:$Force
+                Param ($Force, $Passthru, $Name)
+                Import-Module -Name $Name -PassThru:$Passthru -Force:$Force
 
-        }).AddParameters($Params)
+            }).AddParameters($Params)
 
         ( $PowerShell.Invoke() ).ExportedFunctions.Keys
 
         $PowerShell.Dispose()
     }
-}
+}