-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of maintenance work for the repo #203
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
42d886b
test: make test/run.py DRYer, make dev the default suite, and optimiz…
joanise fc5db32
fix: bump fastapi to minimum Pydantic v2 compatible version
joanise acf2c66
ci: bump actions to node20 version since node16 is deprecated
joanise 2ecadb6
test: quiet the test suites by quenching pointless DEBUG logs
joanise 0268efb
ci: matrix test Python 3.12 too
joanise e36e762
docs: document how our builds on Heroku are controlled
joanise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
Our production Heroku deployment is controlled by the following files: | ||
- `Procfile`: tells Heroku what command to launch in each Dyno; | ||
- `runtime.txt`: tells Heroku which run-time engine to use (i.e., which version of Python); | ||
|
||
Heroku detects Python by default, but `runtime.txt` lets us specify/bump the version as needed; | ||
- `requirements.txt`: tells Heroku what our production dependencies are. | ||
|
||
Updating `g2p`: | ||
- By default, `g2p` only gets updated for `readalong-studio` on Heroku when: | ||
- we make a new release of `g2p` on PyPI | ||
- we update `requirements.min.txt` here to ask for that release | ||
- Manual override: it is also possible to update g2p to the current commit on the `main` branch using this procedure: | ||
- Change `requirements.min.txt` to specify `g2p @ git+https://github.com/roedoejet/g2p@main`. | ||
- Commit that change to `main` in a sandbox connected to Heroku. | ||
- `git push heroku main` | ||
- This will force a build which will fetch the main branch of g2p from GitHub. | ||
- Subsequent builds reuse the cached g2p, so they'll reuse this one. Exception: if `runtime.txt` is updated, a fresh build is done and g2p will be reverted to the latest published version. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,8 +5,7 @@ click>=8.0.4 | |
coloredlogs>=10.0 | ||
# Need to install this specifically from git as the sdist is broken | ||
editdistance @ git+https://github.com/roy-ht/[email protected] ; python_version == '3.12' | ||
fastapi>=0.78.0 | ||
# Note: when we move g2p to >=2, we will need fastapi>=0.100.0 which requires httpx | ||
fastapi>=0.100.0 | ||
g2p>=1.1.20230822, <2.1 | ||
httpx>=0.24.1 | ||
lxml==4.9.4 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the beauty of logging 😉