A bunch of maintenance work for the repo #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a bit While we do not need to really optimize test suites, test_web_api.py load time was annoying me while testing run.py, so I tucked its expensive imports away.
audio_utils.py: we only ever want to see errors from pydub, no debug info, so set the pydub.converter logger to WARNING. This mostly has the effect of quietting previously very verbose test suites, but in general we just don't want to see DEBUG and INFO from pydub, WARNING and ERROR messages are plenty. basic_test_case.py: don't start by setting the log level to DEBUG, and in tearDown(), when it's DEBUG reset it to INFO, so an individual case can trigger DEBUG, e.g., with --debug, and test the effect, without making the rest of the suite verbose. remaining wish item I can't solve: test_force_align.py calls align_audio with debug_aligner=True once, for coverage, but I cannot figure out how to capture the logs from SoundSwallower, its own C stdout/stderr do not seem to be redirectable from Python.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 87.04% 87.05% +0.01%
==========================================
Files 21 21
Lines 1744 1746 +2
Branches 315 315
==========================================
+ Hits 1518 1520 +2
Misses 189 189
Partials 37 37 ☔ View full report in Codecov by Sentry. |
|
roedoejet
approved these changes
Feb 2, 2024
| from typing import Union | ||
|
|
||
| from pydub import AudioSegment | ||
|
|
||
| from readalongs.log import LOGGER | ||
|
|
||
| # quiet pydub's logging |
There was a problem hiding this comment.
ah, the beauty of logging 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commit messages for what's all in here.