Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated DTD to support annotations #236

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented Jul 29, 2024

PR Goal?

The goal of the PR is to provide support for annotation layers in the read along. If a .readalong has annotation layers, it should be acceptable to the CLI

Fixes?

n/a

Feedback sought?

sanity check

Priority?

high

Tests added?

yes

How to test?

cd test/data; readalongs align -o html -f -l fra ej-fra-annotated.readalong ej-fra.m4a ej-fra-annotated

Confidence?

High

Version change?

n/a

required for ReadAlongs/Studio-Web#330

@deltork deltork requested a review from roedoejet July 29, 2024 14:23
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (6087b74) to head (a559040).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   87.60%   87.21%   -0.40%     
==========================================
  Files          21       21              
  Lines        1783     1783              
  Branches      323      323              
==========================================
- Hits         1562     1555       -7     
- Misses        183      189       +6     
- Partials       38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deltork deltork self-assigned this Jul 29, 2024
@deltork deltork force-pushed the dev.del/dtd.patch branch from 904dead to 998b4c4 Compare August 1, 2024 13:29
@deltork deltork force-pushed the dev.del/dtd.patch branch from 998b4c4 to 2e60bf0 Compare August 1, 2024 13:32
Copy link
Collaborator

@dhdaines dhdaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good! Except, should we increment the version number on the DTD?

@deltork
Copy link
Collaborator Author

deltork commented Aug 16, 2024

This seems good! Except, should we increment the version number on the DTD?

I will bump up the format version to 1.2

@deltork deltork requested a review from dhdaines August 16, 2024 13:23
Copy link
Collaborator

@dhdaines dhdaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good now!

@joanise
Copy link
Member

joanise commented Aug 19, 2024

I'm guessing CI fails here due (at least in part) to the panphon issue. Releasing g2p 2.1.0 or restricting panphon<0.21 might be needed temporarily.

@joanise joanise force-pushed the dev.del/dtd.patch branch 2 times, most recently from b11b79f to 3df7249 Compare August 19, 2024 20:38
@joanise joanise force-pushed the dev.del/dtd.patch branch from 3df7249 to 7b9069a Compare August 19, 2024 20:44
@joanise
Copy link
Member

joanise commented Aug 19, 2024

I fixed CI now. There were two problems, in the end:

@deltork deltork merged commit d4b8a69 into main Aug 26, 2024
6 checks passed
@deltork deltork deleted the dev.del/dtd.patch branch August 26, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants