-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Updated DTD to support annotations #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 87.60% 87.21% -0.40%
==========================================
Files 21 21
Lines 1783 1783
Branches 323 323
==========================================
- Hits 1562 1555 -7
- Misses 183 189 +6
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
904dead
to
998b4c4
Compare
998b4c4
to
2e60bf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good! Except, should we increment the version number on the DTD?
I will bump up the format version to 1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good now!
I'm guessing CI fails here due (at least in part) to the panphon issue. Releasing g2p 2.1.0 or restricting |
b11b79f
to
3df7249
Compare
3df7249
to
7b9069a
Compare
I fixed CI now. There were two problems, in the end:
|
PR Goal?
The goal of the PR is to provide support for annotation layers in the read along. If a .readalong has annotation layers, it should be acceptable to the CLI
Fixes?
n/a
Feedback sought?
sanity check
Priority?
high
Tests added?
yes
How to test?
cd test/data; readalongs align -o html -f -l fra ej-fra-annotated.readalong ej-fra.m4a ej-fra-annotated
Confidence?
High
Version change?
n/a
required for ReadAlongs/Studio-Web#330