support allowlist during registration #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindgrenj6
force-pushed
the
allowlist_ips
branch
2 times, most recently
from
1bf992f to
e6fc7b6
Compare
lindgrenj6
force-pushed
the
allowlist_ips
branch
from
e6fc7b6 to
ec206ba
Compare
lphiri
reviewed
Feb 5, 2024
lphiri
reviewed
Feb 5, 2024
lindgrenj6
force-pushed
the
allowlist_ips
branch
from
324087c to
8946717
Compare
lindgrenj6
force-pushed
the
allowlist_ips
branch
2 times, most recently
from
43159c6 to
9850107
Compare
lphiri
reviewed
Feb 8, 2024
lphiri
reviewed
Feb 8, 2024
lindgrenj6
force-pushed
the
allowlist_ips
branch
from
9850107 to
fb3388a
Compare
lindgrenj6
force-pushed
the
allowlist_ips
branch
from
fb3388a to
3840d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API looks like this:
GET /v1/allowlistlists all blocks that are allowed to register for the current org_adminPOST /v1/allowlistallowlists a block of IPs,{"ip_block": "1.2.3.4/32"}, can only be done by org adminsDELETE /v1/allowlist?block={address}removes an IP from the allowlist, only org admins againThe registration create handler now checks the allowlist for the
x-forwarded-forheader before letting the registration go through.