Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSCE-245 - Add pydantic for basic data validation of Trestle Rule #50

Merged
merged 6 commits into from
Oct 9, 2023
Merged

PSCE-245 - Add pydantic for basic data validation of Trestle Rule #50

merged 6 commits into from
Oct 9, 2023

Commits on Oct 3, 2023

  1. refactor: reworks csv_to_yaml for pydantic 

    Update write empty keys to write default keys
Create transformer for CSV reading and writing
Moves CSV specific logic t csv_transformer
Moves YAML specific logic to yaml_transformer and adds writing logic

Signed-off-by: Jennifer Power <[email protected]>
    @jpower432
    jpower432 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    4f8d388 View commit details
    Browse the repository at this point in the history

  2. docs: updates comment 

    Signed-off-by: Jennifer Power <[email protected]>
    @jpower432
    jpower432 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    39da77d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. docs: improves comment and variable naming 

    Signed-off-by: Jennifer Power <[email protected]>
    @jpower432
    jpower432 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8cd41d5 View commit details
    Browse the repository at this point in the history

  2. refactor: reduce extra code in RulesYAMLTransformer for simplicity 

    Signed-off-by: Jennifer Power <[email protected]>
    @jpower432
    jpower432 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    693620d View commit details
    Browse the repository at this point in the history

  3. feat: adds Field aliases to remove underscores from YAML 

    Signed-off-by: Jennifer Power <[email protected]>
    @jpower432
    jpower432 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    78df3d8 View commit details
    Browse the repository at this point in the history

  4. refactor: breaks transformer into ToRuleTransformer and FromRuleTrans… 

    …former

To align with upstream trestle, the transformers are broken down into single
responsibilties and importing the Transformer Base.

Signed-off-by: Jennifer Power <[email protected]>
    @jpower432
    jpower432 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    56c5b52 View commit details
    Browse the repository at this point in the history