PSCE-245 - Add pydantic for basic data validation of Trestle Rule #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update write empty keys to write default keys Create transformer for CSV reading and writing Moves CSV specific logic t csv_transformer Moves YAML specific logic to yaml_transformer and adds writing logic Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
|
@afflom PTAL. This does a bit of reorganization and a couple fixes for adding pydantic for data validation. The YAML Builder is retained for its original intention of doing the CSV to YAML migration. Format specific implementations have been abstracted to the transformer. Let me know what you think! |
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
|
@afflom Converted back to draft for a little bit of rework on the Transformer classes. |
…former To align with upstream trestle, the transformers are broken down into single responsibilties and importing the Transformer Base. Signed-off-by: Jennifer Power <[email protected]>
10 tasks
afflom
approved these changes
Oct 9, 2023
jpower432
added a commit
to jpower432/trestle-bot
that referenced
this pull request
Oct 9, 2023
…dHatProductSecurity#50) * refactor: reworks csv_to_yaml for pydantic Update write empty keys to write default keys Create transformer for CSV reading and writing Moves CSV specific logic t csv_transformer Moves YAML specific logic to yaml_transformer and adds writing logic Signed-off-by: Jennifer Power <[email protected]> * docs: updates comment Signed-off-by: Jennifer Power <[email protected]> * docs: improves comment and variable naming Signed-off-by: Jennifer Power <[email protected]> * refactor: reduce extra code in RulesYAMLTransformer for simplicity Signed-off-by: Jennifer Power <[email protected]> * feat: adds Field aliases to remove underscores from YAML Signed-off-by: Jennifer Power <[email protected]> * refactor: breaks transformer into ToRuleTransformer and FromRuleTransformer To align with upstream trestle, the transformers are broken down into single responsibilties and importing the Transformer Base. Signed-off-by: Jennifer Power <[email protected]> --------- Signed-off-by: Jennifer Power <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basic data validation with pydantic and refactors transformers using a strategy pattern to make the transformers reusable and able to extend to new formats.
Blocked by #47
Type of change
How has this been tested?
Checklist