Bookings empty query #226
Merged
Bookings empty query #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cekk
requested changes
Feb 19, 2025
| @@ -87,6 +95,9 @@ def query(self): | |||
| if review_state: | |||
| query["review_state"] = review_state | |||
|
|
|||
| if len(query) <= empty_query_len: | |||
| raise BadRequest(_("No search parameters were passed.")) | |||
There was a problem hiding this comment.
if you want to translate this message, you have to wrap it into a api.portal.translate:
api.portal.translate(_("No search parameters were passed."))
and i don't see updated *po files
There was a problem hiding this comment.
It doesn't need translation right now but the code is adaptable for translation if needed in future
There was a problem hiding this comment.
Use a msgid, please..after that, i can approve it
Pull Request Test Coverage Report for Build 13498751521Details
💛 - Coveralls |
|
@cekk rw pls |
cekk
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 400 if empty query was passed to
@bookingsendpoint