Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: add https-proxy-agent to fetch requests" #1458

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Revert "fix: add https-proxy-agent to fetch requests" #1458

merged 1 commit into from
Feb 29, 2024

Conversation

RomanHotsiy
Copy link
Member

We have to revert it temporary as we have a major problem caused by this in one of our other tools.

Reverts #1433

@RomanHotsiy RomanHotsiy requested review from a team as code owners February 29, 2024 15:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: 8b9f666

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RomanHotsiy RomanHotsiy merged commit 93e42db into main Feb 29, 2024
13 of 14 checks passed
@RomanHotsiy RomanHotsiy deleted the revert-1433-fix/https-proxy-issues-fix branch February 29, 2024 15:13
@github-actions GitHub Actions
Copy link
Contributor

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.011 ± 0.026 0.986 1.070 1.01 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.005 ± 0.015 0.979 1.024 1.00

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 76.92% 4450/5785
🟡 Branches 67.05% 2358/3517
🟡 Functions 70.22% 724/1031
🟡 Lines 77.11% 4181/5422

Test suite run success

716 tests passing in 101 suites.

Report generated by 🧪jest coverage report action from 8b9f666

@RomanHotsiy RomanHotsiy mentioned this pull request Feb 29, 2024
Merged
4 tasks
malis42 added a commit that referenced this pull request Feb 29, 2024
@malis42
Reapply "fix: add https-proxy-agent to fetch requests (#1433)" (#1458)
a756aac 
This reverts commit 93e42db.
@malis42 malis42 mentioned this pull request Mar 1, 2024
Merged
5 tasks
malis42 added a commit that referenced this pull request Mar 4, 2024
@malis42
fix: fix issues with https-agent-proxy for cli and openapi-core packa…
7ec5cfc 
…ges (#1461)

* Reapply "fix: add https-proxy-agent to fetch requests (#1433)" (#1458)
* fix: add https-proxy-agent package to browser excluded packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marshevskyy Marshevskyy Marshevskyy approved these changes

@tatomyr tatomyr tatomyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanHotsiy @Marshevskyy @tatomyr