Skip to content

Commit

Permalink
Incorporate feedback from code review
Browse files Browse the repository at this point in the history
In general, this was just implementing @agitter's suggested changes. One of the questions
that was raised was why I unpinned the version of docutils. I had to double check, but it
looks like pinning the version caused a compatibility issue, specifically with the pip-
installed package `sphinx-rtd-theme`. Rather than unpinning Docutils or bumping it down by
a version, I bumped `sphinx-rtd-theme` up two versions (in both `environment.yaml` and
the `pyproject.toml`) to satisfy the dependency conflict. The change appears not to have
caused issues, but I'm also not aware of how the doc-building mechanism works, so I'm
not sure how to give it a more robust test.
  • Loading branch information
jhiemstrawisc committed Sep 29, 2023
1 parent 0b7fdd2 commit dfd2493
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
- python=3.8
- pip=22.1
- requests=2.28
- scikit-learn=1.1
- scikit-learn=1.2
- seaborn=0.12
- spython=0.2
# Only required for GraphSpace
Expand All @@ -25,4 +25,4 @@ dependencies:
- sphinx=5.0
- pip:
- graphspace_python==1.3.1
- sphinx-rtd-theme==1.0.0
- sphinx-rtd-theme==1.2.0
22 changes: 13 additions & 9 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
[project]
name = "SPRAS"
version = "v0.0.1"
description = "Signaling Pathway Reconstruction Analysis Streamliner (SPRAS)"
name = "spras"
version = "0.0.1"
description = "Signaling Pathway Reconstruction Analysis Streamliner"
authors = [
{ name = "Anthony Gitter", email = "[email protected]" },
{ name = "Anthony Gitter", email = "[email protected]" },
{ name = "Anna Ritz", email = "[email protected]"},
]
license = { file = "LICENSE" }
readme = "README.md"
classifiers = [
"Programming Language :: Python :: 3",
"Development Status :: 3 - Alpha",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3",
"Topic :: Scientific/Engineering :: Bio-Informatics",
]
requires-python = ">=3.8"
dependencies = [
Expand All @@ -22,18 +26,18 @@ dependencies = [
"pandas==1.4",
"pip==22.1",
"requests==2.28",
"scikit-learn==1.2", #Version bumped from 1.1-->1.2 to get past compilation errors. No other errors encountered
"scikit-learn==1.2",
"seaborn==0.12",
"spython==0.2",
# Only required for GraphSpace
"commonmark==0.9",
"docutils", #==0.18
"docutils==0.18",
"jinja2==3.1",
"mock==4.0",
"recommonmark==0.7",
"sphinx==5.0",
"graphspace_python==1.3.1",
"sphinx-rtd-theme==1.0.0",
"sphinx-rtd-theme==1.2.0",
]

[project.optional-dependencies]
Expand All @@ -45,7 +49,7 @@ dev = [

[project.urls]
"Homepage" = "https://github.com/Reed-CompBio/spras"
"Bug Tracker" = "https://github.com/Reed-CompBio/spras/issues"
"Issues" = "https://github.com/Reed-CompBio/spras/issues"

[build-system]
requires = ["setuptools>=64.0"]
Expand Down

0 comments on commit dfd2493

Please sign in to comment.